Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X backport] Keep Run2 EGamma IDs in Run3 nano(v10) #38871

Merged
merged 3 commits into from Aug 5, 2022

Conversation

swagata87
Copy link
Contributor

PR description:

This is a combined backport of #38810 and #38853. This is intended to keep Run2 ID decisions of electron and photon in Run3 nano(v10), as an intermediate solution for early analyses until the latest greatest IDs trained with Run3 samples are available, which would require a few more weeks to converge.

PR validation:

CMSSW compiles.
11634.0 works fine.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2022

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction)

@gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @swertz, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e6a23/26480/summary.html
COMMIT: 6ace3ca
CMSSW: CMSSW_12_4_X_2022-07-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38871/26480/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676144
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 124.56000000000002 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 20.760 KiB Physics/NanoAODDQM
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Jul 30, 2022

both photons and electrons IDs are back.

works in both Winter MC12_2 and current 12_4

https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/168
Screen Shot 2022-07-30 at 10 13 14

Screen Shot 2022-07-30 at 10 18 28

@mariadalfonso
Copy link
Contributor

backport of #38810
backport of #38853

@mariadalfonso
Copy link
Contributor

+xpog

backport inline with master

@mariadalfonso
Copy link
Contributor

@clacaputo, @jpata this is waiting your signature

@clacaputo
Copy link
Contributor

clacaputo commented Aug 2, 2022

@mariadalfonso
Copy link
Contributor

+reconstraction

@clacaputo can you actually sign ?
the bot didn't recognise it

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@clacaputo
Copy link
Contributor

@clacaputo can you actually sign ?
the bot didn't recognise it

Sorry for the typo

@qliphy
Copy link
Contributor

qliphy commented Aug 5, 2022

+1

@cmsbuild cmsbuild merged commit 4110aa5 into cms-sw:CMSSW_12_4_X Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants