HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE

[gk199]

PR description:

Edits are made such that the HCAL Group 0 LUT only sets LLP bits in HB, not HE. Current uHTR firmware only accepts the LUTs with the high bits (bits 12-15) set in HB, not in HE. This can be reversed to set the LUT bits for both HB and HE when the firmware is modified. The initial PR setting the HCAL LUT is in PR #35599, where more details on the specifications are given as well. Discussed with @Michael-Krohn in detail about the HCAL LUT generation.

PR validation:

runTheMatrix passed, tested in CMSSW_12_5_X_2022-07-28-2300.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38896/31330

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for master.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (l1, alca)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type hcal

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76b1df/26533/summary.html
COMMIT: 1913c7c
CMSSW: CMSSW_12_5_X_2022-07-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38896/26533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3668050
• DQMHistoTests: Total failures: 34
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3667994
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: found differences in 1 / 50 workflows

[ChrisMisan]

+alca

• differences in the comparison were expected
• tests pass
• PR changes in line with the description

[tvami]

@Michael-Krohn @gk199 is this relevant for HI only? You didnt mention anything about backports...

[Michael-Krohn]

Thanks for catching that @tvami. This is relevant for the Run3 physics data taking, so if backports are still open to 12_4_X then @gk199 can you also open a PR that backports this to that release?

[tvami]

Well they are closed and open at the same time... :D If this is needed for data taking and it's considered to be fixing a bug, it can go back to 12_4_X for a patch release (possibly coming out tomorrow) @Michael-Krohn

[tvami]

urgent

• based on HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE #38896 (comment) the backport is needed for data-taking

[Michael-Krohn]

This PR is created to match what is done currently on detector in the HCAL uHTRs so it is considered a bug fix

[tvami]

type bugfix

[gk199]

@tvami and @Michael-Krohn I just opened a backport to 12_4_X, #38923, since this is relevant for Run 3 data taking, thanks for catching that.

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1