Fftjet eventsetup fix

[igv4321]

PR description:

Proper use of ESGetToken objects for FFTJet modules, with appropriate esConsumes calls introduced in the module constructors. This is a purely technical fix, with no changes in the results expected.

PR validation:

The usual runTheMatrix tests were run, as well as some private tests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38932/31376

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

• JetMETCorrections/FFTJetModules (analysis)
• JetMETCorrections/FFTJetObjects (analysis)
• RecoJets/FFTJetProducers (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b18be/26582/summary.html
COMMIT: 3e8fd1c
CMSSW: CMSSW_12_5_X_2022-08-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38932/26582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1042.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3669004
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3668974
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical
• private code

[Dr15Jones]

The static analyzer says there are still old uses of EventSetupRecord::get being used in
JetMETCorrections/FFTJetModules/plugins/FFTJetLookupTableESProducer.cc

See
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b18be/26582/llvm-analysis/report-001203.html#EndPath

[igv4321]

Indeed, thank you. Missed that one.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38932/31391

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #38932 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

[makortel]

@cmsbuild, please test

[Dr15Jones]

@igv4321 thanks for making the fix.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b18be/26609/summary.html
COMMIT: 53f9dec
CMSSW: CMSSW_12_5_X_2022-08-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38932/26609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3677948
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3677912
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical
• private code

[qliphy]

+1

[qliphy]

merge