Update alcareco matrix #38951

malbouis · 2022-08-02T20:42:52Z

PR description:

This is a simple PR to update the alcareco matrix so that it is in line with the newly defined alcareco matrix for tier0 and the collisions trigger menu v1.3.

PR validation:

runTheMatrix.py -l 1000,1001,1001.2,1001.3,1002.3

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

malbouis · 2022-08-02T20:44:31Z

test parameters:

workflows = 1000,1001,1001.2,1001.3,1002.3

malbouis · 2022-08-02T20:44:39Z

please test

cmsbuild · 2022-08-02T20:50:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38951/31392

This PR adds an extra 12KB to repository

cmsbuild · 2022-08-02T20:50:37Z

A new Pull Request was created by @malbouis for master.

It involves the following packages:

Configuration/AlCa (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-08-02T22:18:04Z

Configuration/AlCa/python/autoAlca.py

@@ -50,7 +42,7 @@ def buildList(pdList, matrix):
    return stringList

 # Update the lists anytime a new PD is added to the matrix
-autoAlca = { 'allForPrompt'         : buildList(['Charmonium', 'Commissioning', 'DoubleMuParked', 'DoubleMuon', 'DoubleMuonLowMass', 'EGamma', 'HLTPhysics', 'HcalNZS', 'JetHT', 'MET', 'MinimumBias', 'MuOnia', 'MuOniaParked', 'NoBPTX', 'SingleMuon', 'ZeroBias'], AlCaRecoMatrix),
+autoAlca = { 'allForPrompt'         : buildList(['Commissioning', 'EGamma', 'HLTPhysics', 'HcalNZS', 'JetMET', 'Muon', 'NoBPTX', 'ZeroBias'], AlCaRecoMatrix),


Where are TkAlJpsiMuMu+TkAlUpsilonMuMu exercised after these changes?

good point, I forgot to add the ParkingDoubleMuonLowMass PD. will add them now.

cmsbuild · 2022-08-02T22:55:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38951/31399

This PR adds an extra 12KB to repository

cmsbuild · 2022-08-02T22:55:28Z

Pull request #38951 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

malbouis · 2022-08-02T23:03:29Z

please test

malbouis · 2022-08-02T23:32:37Z

please abort

malbouis · 2022-08-02T23:35:13Z

please test

malbouis · 2022-08-03T17:27:47Z

hmm...I forgot to remove DoubleMuParked from the allForPrompt list. :-/
Will update it later today and re-trigger the tests.

cmsbuild · 2022-08-03T23:25:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38951/31414

This PR adds an extra 12KB to repository

cmsbuild · 2022-08-03T23:25:28Z

Pull request #38951 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

malbouis · 2022-08-04T00:03:28Z

please test

cmsbuild · 2022-08-04T04:57:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cb557/26632/summary.html
COMMIT: 37375e3
CMSSW: CMSSW_12_5_X_2022-08-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38951/26632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
138.1 step 2
138.2 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2cb557/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2cb557/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2cb557/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3

Summary:

No significant changes to the logs found
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 3721319
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3721288
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.062 KiB( 53 files compared)
DQMHistoSizes: changed ( 1000.0 ): -0.020 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): -0.020 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 138.5 ): -0.012 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 138.5 ): -0.012 KiB MessageLogger/Warnings
Checked 227 log files, 49 edm output root files, 54 DQM output files
TriggerResults: no differences found

tvami · 2022-08-04T12:26:21Z

+alca

ALCARECO mtx in line with what's used in the T0
test pass

cmsbuild · 2022-08-04T12:26:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-08-05T00:58:51Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Aug 2, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Aug 2, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 2, 2022

mmusich reviewed Aug 2, 2022

View reviewed changes

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Aug 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 2, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2022

cmsbuild added tests-pending and removed tests-started labels Aug 2, 2022

cmsbuild added the tests-rejected label Aug 3, 2022

update alcareco matrix

37375e3

malbouis force-pushed the alca-update_autoAlca-125X branch from 1eb8ee4 to 37375e3 Compare August 3, 2022 23:19

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Aug 3, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 3, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 4, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 4, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 4, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 5, 2022

cmsbuild merged commit f365212 into cms-sw:master Aug 5, 2022

This was referenced Oct 24, 2022

[12_4_X] Remove hardcoded trigger bits from Lumi ALCARECOs #39752

Merged

[124X] Update alcareco matrix #39837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update alcareco matrix #38951

Update alcareco matrix #38951

malbouis commented Aug 2, 2022 •

edited

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

mmusich Aug 2, 2022

malbouis Aug 2, 2022

cmsbuild commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

malbouis commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

tvami commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

qliphy commented Aug 5, 2022

Update alcareco matrix #38951

Update alcareco matrix #38951

Conversation

malbouis commented Aug 2, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

mmusich Aug 2, 2022

Choose a reason for hiding this comment

malbouis Aug 2, 2022

Choose a reason for hiding this comment

cmsbuild commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 2, 2022

malbouis commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

malbouis commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

Comparison Summary

tvami commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

qliphy commented Aug 5, 2022

malbouis commented Aug 2, 2022 •

edited