miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

mmusich · 2022-08-08T14:40:13Z

PR description:

Miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting:

introduce a single siPixelLACalibration::cmToum constant and use it everywhere where relevant;
address the comment at SiPixelLorentzAnglePCLHarvester: fetch precise B-field value from map via inverseBzAtOriginInGeV #38700 (comment)
provide the code for running the LA fit using Chebyshev polynomials instead of regular ones (currently switched off by default)
make the fitting range of the drift vs depth profile configurable;
add more fit diagnostic histograms (covariance matrix status and propagated error from the covariance matrix on the drift at half-width).

PR validation:

cmssw compiles, needs more private testing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Perhaps to be backported to the production release (12.4.X)

mmusich · 2022-08-08T14:41:24Z

@wweiphy @tsusa FYI

cmsbuild · 2022-08-08T14:48:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31465

This PR adds an extra 28KB to repository

cmsbuild · 2022-08-08T14:48:55Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-08-08T14:59:26Z

please test

cmsbuild · 2022-08-08T18:59:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26708/summary.html
COMMIT: 404b8de
CMSSW: CMSSW_12_5_X_2022-08-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3691612
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3691576
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-08-10T14:15:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31485

This PR adds an extra 28KB to repository

cmsbuild · 2022-08-10T14:16:18Z

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

tvami · 2022-08-10T14:16:22Z

@cmsbuild , please test

cmsbuild · 2022-08-10T18:34:21Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26740/summary.html
COMMIT: d3d87a8
CMSSW: CMSSW_12_5_X_2022-08-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26740/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
140.109140.109_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3/step2_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3.log
140.57140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18/step2_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3692440
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-08-15T14:55:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31567

This PR adds an extra 20KB to repository

cmsbuild · 2022-08-15T14:56:10Z

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

tvami · 2022-08-15T15:25:40Z

@mmusich shall we test this? or something more is coming?

mmusich · 2022-08-15T15:27:56Z

or something more is coming?

I am not planning more updates, unless there are more comments.

tvami · 2022-08-15T15:29:54Z

@cmsbuild , please test

cmsbuild · 2022-08-15T19:15:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26828/summary.html
COMMIT: 490e6ae
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38996/26828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3692440
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

tvami · 2022-08-15T19:44:17Z

+alca

tests pass

cmsbuild · 2022-08-15T19:44:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-08-16T01:41:00Z

+1

tvami · 2022-08-16T14:20:25Z

@mmusich I see a segfault in the IBs
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc10/CMSSW_12_5_X_2022-08-16-1100/pyRelValMatrixLogs/run/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG/step5_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG.log#/

can it be due to this?

mmusich · 2022-08-16T14:59:17Z

@tvami

can it be due to this?

yes, it's actually a commit I had not pushed :/
Here it's the fix: #39083

…rverster Fix for `SiPixelLorentzAnglePCLHarvester` after #38996

cmsbuild added this to the CMSSW_12_5_X milestone Aug 8, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Aug 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 8, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 8, 2022

cmsbuild added tests-approved code-checks-pending tests-pending and removed tests-started tests-approved code-checks-approved labels Aug 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 10, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 10, 2022

cmsbuild removed the tests-started label Aug 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 15, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 15, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 15, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 16, 2022

cmsbuild merged commit 612059c into cms-sw:master Aug 16, 2022

mmusich mentioned this pull request Aug 16, 2022

[12.4.X] miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #39075

Merged

mmusich mentioned this pull request Aug 16, 2022

SiPixelLorentzAnglePCLHarvester: protect the computation of the LA error in case of missing covariance matrix #39083

Merged

mmusich deleted the miscellaneousUpdatesToPixelLAHarvester branch August 16, 2022 15:42

cmsbuild mentioned this pull request Aug 17, 2022

Update cuda to 11.7.1 for gcc12 cms-sw/cmsdist#8025

Closed

mmusich mentioned this pull request Aug 20, 2022

Fix for SiPixelLorentzAnglePCLHarvester after #38996 #39122

Merged

cmsbuild added a commit that referenced this pull request Aug 21, 2022

Merge pull request #39122 from mmusich/fixForSiPixelLorentzAnglePCLHa…

631abc3

…rverster Fix for `SiPixelLorentzAnglePCLHarvester` after #38996

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

mmusich commented Aug 8, 2022 •

edited

mmusich commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

mmusich commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

cmsbuild commented Aug 10, 2022

cmsbuild commented Aug 10, 2022

tvami commented Aug 10, 2022

cmsbuild commented Aug 10, 2022

cmsbuild commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

tvami commented Aug 15, 2022

mmusich commented Aug 15, 2022

tvami commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

tvami commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

qliphy commented Aug 16, 2022

tvami commented Aug 16, 2022

mmusich commented Aug 16, 2022

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

Conversation

mmusich commented Aug 8, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

mmusich commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

mmusich commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

Comparison Summary

cmsbuild commented Aug 10, 2022

cmsbuild commented Aug 10, 2022

tvami commented Aug 10, 2022

cmsbuild commented Aug 10, 2022

RelVals-INPUT

Comparison Summary

cmsbuild commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

tvami commented Aug 15, 2022

mmusich commented Aug 15, 2022

tvami commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

Comparison Summary

tvami commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

qliphy commented Aug 16, 2022

tvami commented Aug 16, 2022

mmusich commented Aug 16, 2022

mmusich commented Aug 8, 2022 •

edited