Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalDQM: Revert timing bit to old default, backport of #39058 #39057

Merged
merged 2 commits into from Aug 23, 2022

Conversation

lwang046
Copy link
Contributor

@lwang046 lwang046 commented Aug 15, 2022

PR description:

Corrects the uHTR&L1T HCAL TP mismatch discrepancy seen between L1 and HCAL subdetector. Now the finegrain bit definition in both are the same old default. Can be updated when the HCAL LLP trigger commissioning work completes.

Request to be integrated in the Online DQM Production release at P5.

PR validation:

runTheMatrix.py -l limited -i all --ibeos test okay

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2022

A new Pull Request was created by @lwang046 for CMSSW_12_4_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @DryRun this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@abdoulline
Copy link

@lwang046 I suppose this is a backport and you're going to submit it also to master 12_5_X?

@cmsbuild
Copy link
Contributor

Pull request #39057 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@lwang046 lwang046 changed the title HcalDQM: Revert timing bit to old default HcalDQM: Revert timing bit to old default, backport of #39058 Aug 15, 2022
@qliphy
Copy link
Contributor

qliphy commented Aug 15, 2022

backport of #39058

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5f087/26841/summary.html
COMMIT: 0b5f736
CMSSW: CMSSW_12_4_X_2022-08-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39057/26841/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 16-Aug-2022 09:30:55 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?tried=&xrdcl.requuid=982c0dd3-5384-46f2-9ccf-37a484f33c37
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 16-Aug-2022 09:30:57 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?tried=&xrdcl.requuid=3e843f51-d6a4-45c5-a8a0-05d80362c51f
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 16-Aug-2022 09:30:58 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'generation_step'
   [2] Calling method for module MixingModule/'mix'
   [3] Calling RootInputFileSequence::initTheFile()
   [4] Calling StorageFactory::open()
   [5] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root
      [b] Input file root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root?tried=&xrdcl.requuid=d086bd3e-43ef-4598-a120-ef86b774f136
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 30.030.0_ZMM+ZMMINPUT+DIGI+RECO+HARVEST/step2_ZMM+ZMMINPUT+DIGI+RECO+HARVEST.log
  • 31.031.0_ZTT+ZTTINPUT+DIGI+RECO+HARVEST/step2_ZTT+ZTTINPUT+DIGI+RECO+HARVEST.log
  • 35.035.0_Wjet_Pt_80_120+Wjet_Pt_80_120INPUT+DIGI+RECO+HARVEST/step2_Wjet_Pt_80_120+Wjet_Pt_80_120INPUT+DIGI+RECO+HARVEST.log
Expand to see more relval errors ...

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5f087/26895/summary.html
COMMIT: 0b5f736
CMSSW: CMSSW_12_4_X_2022-08-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39057/26895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677212
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing at P5

@emanueleusai
Copy link
Member

tests completed and PR deployed at P5

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4b13252 into cms-sw:CMSSW_12_4_X Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants