Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DiMuonMassBiasMonitor for Tk Alignment ALCARECO monitoring purposes #39128

Merged
merged 2 commits into from Aug 23, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 21, 2022

PR description:

The purpose of this PR is to expand on the concept introduced at #38378, about adding the DQM monitoring for the ALCARECOTkAlDiMuonAndVertex stream and adds a new DQM Analyzer (DiMuonMassBiasMonitor) to monitor the bias of the di-muon mass system as a function of the component track kinematics.

PR validation:

Relies on the existing unit tests.
The output of it has been uploaded to a test GUI for convenience of inspection and it's available by connecting to:

 ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch

and visiting https://tinyurl.com/2gapbtzy.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_12_4_X for data-taking operations.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39128/31686

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Alignment (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 21, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 21, 2022

type trk,new-feature

@cmsbuild
Copy link
Contributor

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5468b/26960/summary.html
COMMIT: 0a2efc5
CMSSW: CMSSW_12_5_X_2022-08-21-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39128/26960/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39128/31690

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39128 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 21, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5468b/26965/summary.html
COMMIT: 97a3c46
CMSSW: CMSSW_12_5_X_2022-08-21-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39128/26965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693040
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3693015
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 56.991 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 56.983 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants