Fix OOT plot in PPS Diamond DQM

[ChrisMisan]

PR description:

This PR aims to fix the incorrect filling of the OOT histogram in the PPS Diamond DQM. It is correcting two issues:

• by default no_TOT = -1 so it should be filtered out by condition TOT!=-1 or, as recommended by expert, TOT>0
• x coordinate has to take into account number of windows, the shift was hardcoded to 0.25 which is only correct for windowsNum=4

PR validation:

standard tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport to 12_4_X will follow

[ChrisMisan]

type ctpps, bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39132/31701

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefb21/26979/summary.html
COMMIT: 925b217
CMSSW: CMSSW_12_5_X_2022-08-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39132/26979/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @watson-ij Use GEM Rechits (not segments) for GEMMuon #38990
• @carriganm95 updated HLT paths for EXODisappTrk skim #38919
• @cms-tsg-storm HLT menu development for 12_4_X (7/N) [12_5_X] #39113
• @hahnjo Implement specialized tracking manager for e-/e+/gamma #39102

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefb21/26979/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefb21/26979/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 3334 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692530
• DQMHistoTests: Total failures: 5042
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3687454
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -4.074000000000001 KiB( 50 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.844 KiB HLT/Muon
• DQMHistoSizes: changed ( 11634.0,... ): 0.165 KiB HLT/Filters
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: found differences in 7 / 50 workflows

[emanueleusai]

there are many differences in the unit tests. Are these understood?

[ChrisMisan]

@emanueleusai those can't be right, we're literally changing one histogram filling. Those differences have to be associated with some other changes.

[emanueleusai]

ok they are caused by one of the merge commits included on top of IB, probably most of them come from #38990 and the remaining from #39113

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefb21/27028/summary.html
COMMIT: 925b217
CMSSW: CMSSW_12_5_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39132/27028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693060
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

+1