PPS NANOAOD dependency hotfix

[grzanka]

PR description:

This PR resolves an issue reported by @mariadalfonso in #39197 (comment)
Production of proton tables in PPS NANOAOD builders used a filtering method (set of Proton POG quality checks) which was implemented as an EDProducer located in RecoCTPPS/ProtonReconstruction/plugins/PPSFilteredProtonProducer.cc.
With that modification this filtering is disabled, removing dependencies on RecoCTPPS/ProtonReconstruction, instead proton data is directly taken from MINIAOD collection.

We foresee adding in the future another modification which enables to use of such filtering in an on-demand scenario and with proper dependencies.

PR validation:

The limited battery of tests shows no errors (runTheMatrix).
Impact on the NANOAOD production was cross-checked by the proton POG group (@diemort )

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39294/31974

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @grzanka (Leszek Grzanka) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39294/31979

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #39294 was updated. @cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f538/27328/summary.html
COMMIT: fc5c864
CMSSW: CMSSW_12_6_X_2022-09-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39294/27328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 27
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618161
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[vlimant]

integration test running https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/pipelines/4459639

[forthommel]

It does not seem like the tau module failure (pat::Tau: the ID byVVVLooseDeepTau2018v2p5VSjet can't be found in this pat::Tau.) is any related to this PR, right?

[vlimant]

please bear with me.
integration test running https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/181

[grzanka]

@vlimant what is the status of the integration testing ?

[vlimant]

+1
all changes now look sensible

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

(Checking): shouldn't ctppsProtons be added to the task in place ot filteredProtons here?

[perrotta]

(Checking): shouldn't ctppsProtons be added to the task in place ot filteredProtons here?

@grzanka

[forthommel]

@grzanka please confirm, but I believe this task should only include protonTable and multiRPTable. @perrotta, ctppsProtons is actually the sequence we would like to strip from the NANOAODification.

[perrotta]

+1