Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPS NANOAOD dependency hotfix #39294

Merged
merged 2 commits into from Sep 15, 2022
Merged

PPS NANOAOD dependency hotfix #39294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42cfbc8
Removing ddependency on the Reco package
grzanka Sep 2, 2022
fc5c864
Apply suggestions from code review
grzanka Sep 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 5 additions & 13 deletions PhysicsTools/NanoAOD/python/protons_cff.py
View file
Open in desktop
Expand Up @@ -2,26 +2,18 @@
from PhysicsTools.NanoAOD.common_cff import *
from PhysicsTools.NanoAOD.genProtonTable_cfi import genProtonTable as _genproton
from PhysicsTools.NanoAOD.nano_eras_cff import *
from RecoPPS.ProtonReconstruction.ppsFilteredProtonProducer_cfi import *

singleRPProtons = True

filteredProtons = ppsFilteredProtonProducer.clone(
protons_single_rp = cms.PSet(
include = cms.bool(singleRPProtons)
)
)

protonTable = cms.EDProducer("ProtonProducer",
tagRecoProtonsMulti = cms.InputTag("filteredProtons", "multiRP"),
tagRecoProtonsSingle = cms.InputTag("filteredProctppsProtonstons", "singleRP"),
grzanka marked this conversation as resolved.
Show resolved Hide resolved
tagRecoProtonsMulti = cms.InputTag("filteredProctppsProtonstons", "multiRP"),
grzanka marked this conversation as resolved.
Show resolved Hide resolved
tagTrackLite = cms.InputTag("ctppsLocalTrackLiteProducer"),
storeSingleRPProtons = cms.bool(singleRPProtons)
)
protonTable.tagRecoProtonsSingle = cms.InputTag("filteredProtons" if singleRPProtons else "ctppsProtons","singleRP")


multiRPTable = cms.EDProducer("SimpleProtonTrackFlatTableProducer",
src = cms.InputTag("filteredProtons","multiRP"),
src = cms.InputTag("ctppsProtons","multiRP"),
cut = cms.string(""),
name = cms.string("Proton_multiRP"),
doc = cms.string("bon"),
Expand All @@ -42,7 +34,7 @@
)

singleRPTable = cms.EDProducer("SimpleProtonTrackFlatTableProducer",
src = cms.InputTag("filteredProtons","singleRP"),
src = cms.InputTag("ctppsProtons","singleRP"),
cut = cms.string(""),
name = cms.string("Proton_singleRP"),
doc = cms.string("bon"),
Expand All @@ -58,7 +50,7 @@
),
)

protonTablesTask = cms.Task(filteredProtons,protonTable,multiRPTable)
protonTablesTask = cms.Task(protonTable,multiRPTable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Checking): shouldn't ctppsProtons be added to the task in place ot filteredProtons here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Checking): shouldn't ctppsProtons be added to the task in place ot filteredProtons here?

@grzanka

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzanka please confirm, but I believe this task should only include protonTable and multiRPTable. @perrotta, ctppsProtons is actually the sequence we would like to strip from the NANOAODification.

if singleRPProtons: protonTablesTask.add(singleRPTable)

# GEN-level signal/PU protons collection
Expand Down