Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39309/31994
|
|
A new Pull Request was created by @mrcthiel for master. It involves the following packages:
@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8ab1/27366/summary.html Comparison SummarySummary:
|
|
Integration test running: https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/191 |
|
@mrcthiel apologies for the delay. In #39069 the following filters are also listed for 2016: but I don't see them added here, and indeed 2016 samples don't see any changes in muon and photon trigger objects. Are those not needed? About this:
There will be no backports to 12_4_X as NanoV10 is now closed in 12_4_8. |
|
I already included 2016 paths by hand in my private area, so I do not need them. I just asked for the other paths (used in 2017 and 2018) thinking in the Run III data. |
|
If these filter bits are relevant, other people analyzing 2016 data might want to use them, so I think for completeness it would be good to include them as well, thanks. |
|
ok, I can do a new PR in the next few days. |
|
Thanks, but feel free to push to this PR, no need for a new one. |
|
@mrcthiel will you update the PR with the 2016 filters? Also, we have now decided that we would backport changes to the trigger object filter names to 124X to allow prompt nano to pick up those changes, even if it breaks compatibility with Run2 or existing V10 samples. Can you please also make a backport to 124X ? In principle the same changes should then also be applied to the frozen V10 config in master, in this PR: https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py |
|
Sorry, I didn't update yet, I'm debugging another problem with 2016 filters. It seems there is a problem with the filter on 2016H and for 2016 MC, which uses the same path but is different from 2016B-G. If you have urgency for the backport I would propose keeping the 2017-2018 filters and I'll keep debugging for 2016, let me know. |
|
Ok we can run with what you have here - as I said more work is needed on those objects anyway. Can you just please apply the same changes to https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py before you make the backport to 124X? |
|
enable nano |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8ab1/28663/summary.html Comparison SummarySummary:
NANO Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
Nano size comparison Summary:
|
|
+1 Only differences seen in nanoAOD trigger objects for muons and photons. @mrcthiel please prepare the 12_4_X backport ASAP. |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1
|
Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCaloId_v* as requested in #39069.
To be backported to 12_4_8.