Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in TOP-HLT DQM : Deepjet HLT path monitoring & flag to enable/disable production of 2d histos (backport of #39205)) #39648

Merged
merged 2 commits into from Oct 11, 2022

Conversation

ckoraka
Copy link
Contributor

@ckoraka ckoraka commented Oct 6, 2022

PR description:

This PR implements a cleanup of the Top PAG HLT Offline DQM code. Changes were made in certain files under DQMOffline/Trigger:
plugins/TopMonitor.cc
python/TopMonitor_cfi.py
python/TopMonitoring_Client_cff.py
python/TopMonitoring_cff.py

Changes :

  • A flag to enable and disable the creation of 2D DQM plots was added (enable2DPlots) and was set to True by default.
    • This flag was set to False in the TOP HLT DQM module configuration :
      • 2-d histograms under sub-folders HLT/TOP/* will not be produced.
  • Added monitoring of the following HLT paths :
    1. HLT_PFHT400_SixPFJet32_DoublePFBTagDeepJet_2p94_v
    2. HLT_PFHT450_SixPFJet36_PFBTagDeepJet_1p59_v
      As a result, two additional sub-folders are expected to be produced:
      HLT/TOP/FullyHadronic/DoubleBTagDeepJet
      HLT/TOP/FullyHadronic/SingleBTagDeepJet
      Note : The deepCSV tagger is used for the selection of offline b-tagged jets since the deepjet b-tag handle is not available at RECO level. The compatibility of the trigger efficiency derived when selecting offline b-tagged jets with the deepjet vs the deepcsv tagger can be seen in slide 6 of this presentation. In the future we could consider calculating the deep-jet outputs of the offline jets on-the-fly.

No changes are expected in any of the previously produced histograms in folders other than HLT/TOP

PR validation:

Tested with runTheMatrix.py -l 11634.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #39205. The updates in the offline DQM monitoring are needed also in CMSSW_12_4_X so that results are available in dqm GUI.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2022

A new Pull Request was created by @ckoraka for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce10ce/28093/summary.html
COMMIT: 3bc8069
CMSSW: CMSSW_12_4_X_2022-10-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39648/28093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671516
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 43
  • DQMHistoTests: Total successes: 3671438
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3110.902 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 518.483 KiB HLT/TOP
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #39205

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3bc901e into cms-sw:CMSSW_12_4_X Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants