Updates in TOP-HLT DQM : Deepjet HLT path monitoring & flag to enable/disable production of 2d histos

[ckoraka]

PR description:

This PR implements a cleanup of the Top PAG HLT Offline DQM code. Changes were made in certain files under DQMOffline/Trigger:
plugins/TopMonitor.cc
python/TopMonitor_cfi.py
python/TopMonitoring_Client_cff.py
python/TopMonitoring_cff.py

Changes :

• A flag to enable and disable the creation of 2D DQM plots was added (enable2DPlots) and was set to True by default.
  • This flag was set to False in the TOP HLT DQM module configuration :
    • 2-d histograms under sub-folders HLT/TOP/* will not be produced.
• Added monitoring of the following HLT paths :
  1. HLT_PFHT400_SixPFJet32_DoublePFBTagDeepJet_2p94_v
  2. HLT_PFHT450_SixPFJet36_PFBTagDeepJet_1p59_v
     As a result, two additional sub-folders are expected to be produced:
     HLT/TOP/FullyHadronic/DoubleBTagDeepJet
     HLT/TOP/FullyHadronic/SingleBTagDeepJet
     Note : The deepCSV tagger is used for the selection of offline b-tagged jets since the deepjet b-tag handle is not available at RECO level. The compatibility of the trigger efficiency derived when selecting offline b-tagged jets with the deepjet vs the deepcsv tagger can be seen in slide 6 of this presentation. In the future we could consider calculating the deep-jet outputs of the offline jets on-the-fly.

No changes are expected in any of the previously produced histograms in folders other than HLT/TOP

• Performed needed updates with respect to PR39158

PR validation:

Tested with runTheMatrix.py -l 11634.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a back-port, and no back-port of this is planned.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39205/31817

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @ckoraka for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@HuguesBrun, @mtosi, @Fedespring, @missirol, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3a4dd/27176/summary.html
COMMIT: 5421229
CMSSW: CMSSW_12_6_X_2022-08-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39205/27176/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3689822
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 43
• DQMHistoTests: Total successes: 3689734
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 3110.902 KiB( 50 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 518.483 KiB HLT/TOP
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• there are a couple of MEs in MTD and L1T showing differences but those cannot be coming from this PR
• previous issue of change propagating to other PAGs HLT histos has been fixed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

A flag to enable and disable the creation of 2D DQM plots was added (enable2DPlots) and was set to False.

• 2-d histograms under sub-folders HLT/TOP/* will not be produced.

In this PR the flag enable2DPlots is set to True by default, and modified to False individually in all modules one by one. New modules will have therefore that flag set to True, unless it is explicitely modified in the module configuration. If this is actually what you want, please modify the PR description accordingly.

[ckoraka]

@emanueleusai thank you for confirming.

@perrotta thanks for pointing this out! The default, as you mention, is to have the flag set to True as the 2D plots in all modules were being produced before this flag was added. The goal was to disable the 2d plot production only in the TOP HLT DQM module. I clarified this further in the PR description.

[perrotta]

+1