Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & bug fix for offline DQM for EXO & HIG Run 3 muon paths #39799

Merged
merged 1 commit into from Oct 25, 2022

Conversation

jalimena
Copy link
Contributor

PR description:

This PR:

  1. removes the offline DQM monitoring of two obsolete HLT paths, which are no longer in the 2022 menu: HLT_TrkMu16_DoubleTrkMu6NoFiltersNoVtx_v and HLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v
  2. make it not required to have all paths be valid in the numerator and denominator, for the paths monitored in MuonMonitor_cff

The reason for the second part is because in the HLT 2022 v1.3 menu, one of the paths in the denominator was removed. As a result, the DQM plots did not get made, although they would have been fine, physics-wise. Changing this flag to false is the easiest way to have similar DQM plots with the earlier and later HLT menus, and it fixes this bug.

As a result of this PR, some DQM plots will be removed, and some will reappear.

PR validation:

Using the 11634.0 ttbar workflow, I have tested that the correct histograms are produced and filled in the harvested DQM file.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will need to be backported to 12_4_X, so it will go into the DQM offline GUI.

…tersNoVtx_v and HLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v; make it not required to have all paths valid in the numerator and denominator
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39799/32669

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b2ef5/28411/summary.html
COMMIT: 439a112
CMSSW: CMSSW_12_6_X_2022-10-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39799/28411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391130
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8784.918 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 971.459 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): 969.768 KiB HLT/EXO
  • DQMHistoSizes: changed ( 139.001 ): 1023.392 KiB HLT/EXO
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

1 similar comment
@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants