Shashlik fix HGcal

[shervin86]

This commits fix the crashing of the 12200 workflow.
The second commit works, but I'm not sure if this is the correct thing to do.
I've sent an email to Jeremy Mans.

[cmsbuild]

A new Pull Request was created by @shervin86 for CMSSW_6_2_X_SLHC.

Shashlik fix HGcal

It involves the following packages:

Geometry/CaloEventSetup
SimCalorimetry/EcalSimProducers

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[andersonjacob]

@kpedro88 - can you have a look at these lines and check that they make sense to you?

[kpedro88]

This looks fine to me. If there is no EE geometry defined at all, there should not be any EE cells to add to the CaloTowers.

[mark-grimes]

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12400, 12800, 13000, 13600, 13800, 14000 and 14600 pass all steps.
Test 12600 fails in step 2 with the same error as before

%MSG-e HGCalGeom:  MixingModule:mix 23-May-2014 17:18:09 CEST Run: 1 Event: 1
ShashlikGeometry::getGeometry-> inconsistent geometry structure 1008759920(32874->1006686810) inside: (EK iz -  fiber 0, RO 0, ix 210, iy 90)(1006686810->32874) given: (EK iz +  fiber 0, RO 0, ix 116, iy 112)(1008759920) ref (EK iz -  fiber 0, RO 0, ix 210, iy 90)
%MSG
cmsRun: /build/cmsbuild/jenkins-workarea/workspace/ib-CMSSW_6_2_X_SLHC-slc5_amd64_gcc472/267/w/tmp/BUILDROOT/96bfd5ca31f0ada2376becf146a6df7a/opt/cmssw/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-05-23-0200/src/SimCalorimetry/EcalSimAlgos/src/EcalHitResponse.cc:283: double EcalHitResponse::timeOfFlight(const DetId&) const: Assertion `0 != cellGeometry' failed.

Tests 12200, 14200 and 14400 now pass step 2 but fail in step3.

cmsRun: <build path>/src/RecoEgamma/EgammaIsolationAlgos/src/EgammaRecHitIsolation.cc:64: EgammaRecHitIsolation::EgammaRecHitIsolation(double, double, double, double, double, edm::ESHandle<CaloGeometry>, CaloRecHitMetaCollectionV*, const EcalSeverityLevelAlgo*, DetId::Detector): Assertion `subdet_[1]!=__null' failed.

Ideally should wait for confirmation from @kpedro88 or Jeremy Mans (don't know his github name) but I'm inclined to merge it anyway since it moves things in the right direction.

[andersonjacob]

The error in 12600 is very perplexing. I would have expected it in 12400, 13800 and 14000 if it were fundamental. I wonder if it is an inconsistency in the customization or some other part of the configuration?

[andersonjacob]

merge