Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (10/N): HLT V1.5 of 2022 [12_5_X] #39925

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Oct 29, 2022

backport of #39924

PR description:

Development of HLT menus for CMSSW_12_4_X.

This version of the GRun HLT menu corresponds to "HLT V1.5" for 2022 pp data-taking.

Additionally, the HIon L1T menu used in HLT-specific tests is updated to the candidate L1T menu for the HIon 2022 test run (CMSLITDPG-1015): L1Menu_CollisionsHeavyIons2022_v1_1_0 (tag in CondDB).

Due to the update of the HIon menu, the DIGIHI2018PPRECO RelVal step is moved to the Fake2 HLT menu (like other Run-2 wfs); this affects wfs 158.{0,1,2,3,5}, whose DQM sequences already expect a "fake" HLT. These wfs were using the HIon HLT menu, which, after this PR, is not compatible anymore with the L1T menu in auto:phase1_2018_realistic_hi.

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2366: [BTV] disable DeepCSV triggers of GRun
  • CMSHLT-2476: [TSG] seed of HLT_EphemeralZeroBias changed to L1_ZeroBias_copy
  • CMSHLT-2478: [MUO] removed some HLT-muon modules from suppressWarning list
  • CMSHLT-2491: [TSG] update PSs of HLT_HT300_Beamspot trigger
  • CMSHLT-2495: [TSG] update PSs of Ephemeral triggers
  • CMSHLT-2497: [TSG] added L1T seed to HLT_EphemeralPhysics (L1A Physics "masking" L1_ZeroBias_copy)
  • CMSHLT-2499: [TSG] added L1_SingleTau130er2p1 to L1T seeds using L1_SingleTau120er2p1
  • CMSHLT-2501: [EXO] added L1Tau-seeded delayed-jet triggers
  • CMSHLT-2514: [TSG] disable two displaced-dijet and two PNET triggers
  • CMSHLT-2518: [HIG] update of 1 L1T seed and 2 PSs of MSSM-Hbb control triggers
  • CMSHLT-2519: [TSG] disable 4 fatjet softdrop-mass triggers plus other PS changes
  • CMSHLT-2520: [BTV] updated PSs of BTagMu triggers
  • CMSHLT-2521: [HIN] update of HIon sequences for RawPrime repacking
  • CMSHLT-2523: [HIN] removed outdated HIon triggers
  • CMSHLT-2527: [EXO] updated L1T seed of SingleLLPJet triggers
  • CMSHLT-2532: [HIN] update of Streams/PDs/EventContents for HIon 2022 test run
  • CMSHLT-2534: [JME] doubled PS of AlCa_*PFJet* triggers
  • CMSHLT-2535: [HIN] updated L1T seeds of HIUPC triggers
  • CMSHLT-2537: [TSG] sync PSs of offline menu with V1.4.5 online menu
  • CMSHLT-2539: [TSG] use common PF-scouting sequence in MC_Run3_PFScoutingPixelTracking_v Path

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39924

Development of HLT menus for 2022 data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf4ed5/28633/summary.html
COMMIT: d9210c7
CMSSW: CMSSW_12_5_X_2022-10-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39925/28633/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 158.1158.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
  • 158.2158.2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
  • 158.3158.3_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3702752
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #39925 was updated. @Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

The DIGIHI2018PPRECO RelVal step is moved to the Fake2 HLT menu (like other Run-2 wfs); this affects wfs 158.{0,1,2,3,5}, whose DQM sequences already expect a "fake" HLT. These wfs were using the HIon HLT menu, which, after this PR, is not compatible anymore with the L1T menu in auto:phase1_2018_realistic_hi. This now requires the signature of @cms-sw/pdmv-l2 and @cms-sw/upgrade-l2.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf4ed5/28641/summary.html
COMMIT: 4d67e75
CMSSW: CMSSW_12_5_X_2022-10-30-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39925/28641/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 1107
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3701646
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@srimanob
Copy link
Contributor

+Upgrade

Backport PR.

@missirol
Copy link
Contributor Author

missirol commented Nov 1, 2022

@cms-sw/pdmv-l2 , this backport is missing your signature. Please have a loook.

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 1, 2022

+1

@cmsbuild cmsbuild merged commit c19c2f9 into cms-sw:CMSSW_12_5_X Nov 1, 2022
@missirol missirol deleted the HLTdevelopment124X_for125X branch November 1, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants