[TsosGaussianStateConversions] proposal fix for Gsf Tracking segmentation fault when no states are passing selection criteria

[mmusich]

PR description:

Proposal resolution to issue at #39987. Submitted mostly to check regressions.

PR validation:

It was not yet possible to fully reproduce the issue offline, this solves a "simulated" crash according to the recipe detailed at #39987 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported, if it is determined that there are no regressions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40017/32966

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• TrackingTools/GsfTracking (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @bellan, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

@cmsbuild please test

[slava77]

type tracking

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e651ad/28882/summary.html
COMMIT: a40b3e3
CMSSW: CMSSW_12_6_X_2022-11-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40017/28882/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416402
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416371
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

in principle we might want to backport this and deploy at Tier0 for the last leg of data-taking.

@cms-sw/reconstruction-l2 please also have a look to the related discussion at #39987 (comment)

[clacaputo]

+reconstruction

• attempt for fixing CMSSW_12_4_11 did not fix GSF tracking issue in prompt reco #39987
• the PR doesn't introduce any reco changes
• it adds an extra layer of protection that could fix CMSSW_12_4_11 did not fix GSF tracking issue in prompt reco #39987. See CMSSW_12_4_11 did not fix GSF tracking issue in prompt reco #39987 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Adding an extra protection