Run3-gex145 Change getByLabel to use tokens in Alignment/OfflineValidation #40051

bsunanda · 2022-11-12T06:35:21Z

PR description:

Change getByLabel to use tokens in Alignment/OfflineValidation

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild · 2022-11-12T06:42:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40051/33017

This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40051/33017/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40051/33017/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-11-12T07:01:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40051/33018

This PR adds an extra 48KB to repository

cmsbuild · 2022-11-12T07:01:28Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-11-12T07:09:53Z

@cmsbuild Please test

cmsbuild · 2022-11-12T07:14:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40051/33019

This PR adds an extra 48KB to repository

cmsbuild · 2022-11-12T07:14:27Z

Pull request #40051 was updated. @malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

ChrisMisan

@bsunanda Could you add fillDescriptions as the part of the cleanup?

cmsbuild · 2022-11-12T10:37:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d422f2/28983/summary.html
COMMIT: b48f0d0
CMSSW: CMSSW_12_6_X_2022-11-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40051/28983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416993
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3416968
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

ChrisMisan · 2022-11-14T11:12:43Z

@bsunanda kind reminder

cmsbuild · 2022-12-02T16:58:10Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d422f2/29425/summary.html
COMMIT: 58cc30b
CMSSW: CMSSW_13_0_X_2022-12-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40051/29425/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 32 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3421159
DQMHistoTests: Total failures: 1310
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3419827
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 158 edm output root files, 48 DQM output files
TriggerResults: no differences found

ChrisMisan · 2022-12-03T12:01:40Z

please test

retest

cmsbuild · 2022-12-03T16:01:56Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d422f2/29440/summary.html
COMMIT: 58cc30b
CMSSW: CMSSW_13_0_X_2022-12-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40051/29440/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 34 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3421467
DQMHistoTests: Total failures: 1176
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3420269
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 158 edm output root files, 48 DQM output files
TriggerResults: no differences found

bsunanda · 2022-12-05T01:49:20Z

@cmsbuild Please test

cmsbuild · 2022-12-05T05:41:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d422f2/29455/summary.html
COMMIT: 58cc30b
CMSSW: CMSSW_13_0_X_2022-12-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40051/29455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 39 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3421337
DQMHistoTests: Total failures: 1182
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3420133
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 158 edm output root files, 48 DQM output files
TriggerResults: no differences found

ChrisMisan · 2022-12-05T09:14:52Z

@bsunanda PR description doesn't explain the changes in comparison. Is the source of the difference understood?

mmusich · 2022-12-05T09:20:25Z

@ChrisMisan

PR description doesn't explain the changes in comparison. Is the source of the difference understood?

I think, since the differences are very concentrated in 11634.7 that this is a case of #39803.
This PR has very clearly nothing to do with it.

ChrisMisan · 2022-12-06T10:26:06Z

+alca

differences related to the issue spurious differences in outputs of Run-3 wfs *.7 #39803

cmsbuild · 2022-12-06T10:26:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-12-06T14:34:15Z

+1

Technical PR

cmsbuild added this to the CMSSW_12_6_X milestone Nov 12, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Nov 12, 2022

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Nov 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 12, 2022

bsunanda force-pushed the Run3-gex145 branch from 96276cd to b48f0d0 Compare November 12, 2022 07:02

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 12, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 12, 2022

ChrisMisan reviewed Nov 12, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 12, 2022

cmsbuild added tests-rejected and removed tests-started labels Dec 2, 2022

cmsbuild added tests-started and removed tests-rejected labels Dec 3, 2022

cmsbuild added tests-rejected and removed tests-started labels Dec 3, 2022

cmsbuild added tests-started and removed tests-rejected labels Dec 5, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 5, 2022

mmusich mentioned this pull request Dec 5, 2022

spurious differences in outputs of Run-3 wfs *.7 #39803

Open

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Dec 6, 2022

cmsbuild added orp-approved and removed orp-pending labels Dec 6, 2022

cmsbuild merged commit 55fceca into cms-sw:master Dec 6, 2022

This was referenced Dec 7, 2022

Updates from Igrof master for Ubuntu which might help with EL8 cms-externals/igprof#5

Merged

[G4VECGEOM] Update clhep to 2.4.6.0, vecgeom to 1.2.1 cms-sw/cmsdist#8211

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex145 Change getByLabel to use tokens in Alignment/OfflineValidation #40051

Run3-gex145 Change getByLabel to use tokens in Alignment/OfflineValidation #40051

bsunanda commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

bsunanda commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

ChrisMisan left a comment •

edited

cmsbuild commented Nov 12, 2022

ChrisMisan commented Nov 14, 2022

cmsbuild commented Dec 2, 2022

ChrisMisan commented Dec 3, 2022

cmsbuild commented Dec 3, 2022

bsunanda commented Dec 5, 2022

cmsbuild commented Dec 5, 2022

ChrisMisan commented Dec 5, 2022

mmusich commented Dec 5, 2022

ChrisMisan commented Dec 6, 2022

cmsbuild commented Dec 6, 2022

rappoccio commented Dec 6, 2022

Run3-gex145 Change getByLabel to use tokens in Alignment/OfflineValidation #40051

Run3-gex145 Change getByLabel to use tokens in Alignment/OfflineValidation #40051

Conversation

bsunanda commented Nov 12, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

bsunanda commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

cmsbuild commented Nov 12, 2022

ChrisMisan left a comment • edited

Choose a reason for hiding this comment

cmsbuild commented Nov 12, 2022

Comparison Summary

ChrisMisan commented Nov 14, 2022

cmsbuild commented Dec 2, 2022

RelVals-INPUT

Comparison Summary

ChrisMisan commented Dec 3, 2022

cmsbuild commented Dec 3, 2022

Unit Tests

Comparison Summary

bsunanda commented Dec 5, 2022

cmsbuild commented Dec 5, 2022

Comparison Summary

ChrisMisan commented Dec 5, 2022

mmusich commented Dec 5, 2022

ChrisMisan commented Dec 6, 2022

cmsbuild commented Dec 6, 2022

rappoccio commented Dec 6, 2022

ChrisMisan left a comment •

edited