New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Run 3 muon process using proper DNN b-tagger #40100
Add Run 3 muon process using proper DNN b-tagger #40100
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40100/33085
|
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign alca |
@cmsbuild , please test |
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours.
Comparison SummarySummary:
|
@cmsbuild , please test |
FYI @CeliaFernandez, @andrea21z. There are some differences in wf |
Hi @clacaputo, thank you for informing us. These differences are expected since the b-tagger is an input variable of both MVAs. |
Hi @andrea21z , thanks for your answer. I'm wondering whether there is a need of re-training from your side, considering that one of the inputs has changed |
Hi @andrea21z , do we expect a PR from Muon POG, updating the training of the two MVA? |
Hi @clacaputo, sorry for the delay in answering but we wanted to discuss the status of these two MVA within the Muon POG group first. Right now these MVAs in MiniAOD are not used by any analysis so we believe it is not worth retraining them. |
@clacaputo do you have any further questions? Or can this PR be signed from the |
+reconstruction
|
+1 No changes in Run2 or Run3 nano.
@andrea21z if these MVAs are not supported or used anymore, could you consider removing them from miniAOD and/or nanoAOD? |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@swertz maybe this would be a good "github issue" topic? |
Indeed, done here: https://gitlab.cern.ch/cms-nanoAOD/xpog-coordination/-/issues/46 (we manage XPOG content-related issues there; bugs or issues with the software are still relevant for the CMSSW github) |
PR description:
Regarding the AlCa issue #58 (cms-AlCaDB/AlCaTools#58), old b-tagging GT records are request to be removed (starting) from 12_1_X (and so on). Due to the dependency on "BTauGenericMVAJetTagComputerRcd" and "JetTagComputerRecord", the corresponding b-tagging computers need to be masked in run3. Only DNN taggers will be the only supported ones in run3. To accommodate the change, this PR changes the discriminator to "pfDeepCSVJetTag:probb" in patMuon and patDisplacedMuon with Era Modifier for Run 3.
PR validation:
PR tested locally with runTheMatrix with Run3 era and 125X_mcRun3_2022_realistic_Queue condition on 11603.0 and native run 3 tests 312.0, 139.001 and 13234.0.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport and no backport expected.