Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run 3 muon process using proper DNN b-tagger #40100

Merged
merged 1 commit into from Dec 7, 2022

Conversation

yuanchao
Copy link
Contributor

@yuanchao yuanchao commented Nov 17, 2022

PR description:

Regarding the AlCa issue #58 (cms-AlCaDB/AlCaTools#58), old b-tagging GT records are request to be removed (starting) from 12_1_X (and so on). Due to the dependency on "BTauGenericMVAJetTagComputerRcd" and "JetTagComputerRecord", the corresponding b-tagging computers need to be masked in run3. Only DNN taggers will be the only supported ones in run3. To accommodate the change, this PR changes the discriminator to "pfDeepCSVJetTag:probb" in patMuon and patDisplacedMuon with Era Modifier for Run 3.

PR validation:

PR tested locally with runTheMatrix with Run3 era and 125X_mcRun3_2022_realistic_Queue condition on 11603.0 and native run 3 tests 312.0, 139.001 and 13234.0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport and no backport expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40100/33085

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @AnnikaStein, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 17, 2022

assign alca

@tvami
Copy link
Contributor

tvami commented Nov 17, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d92065/29082/summary.html
COMMIT: 44ffc81
CMSSW: CMSSW_12_6_X_2022-11-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40100/29082/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417122
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417092
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 17, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d92065/29105/summary.html
COMMIT: 44ffc81
CMSSW: CMSSW_12_6_X_2022-11-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40100/29105/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

  • 11846.011846.0_ZEE_14+2021PU+ZEE_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoNanoPU+HARVESTNanoPU/step2_ZEE_14+2021PU+ZEE_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoNanoPU+HARVESTNanoPU.log
  • 21034.11421034.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417167
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 18, 2022

@cmsbuild , please test

@clacaputo
Copy link
Contributor

this PR changes the discriminator to "pfDeepCSVJetTag:probb" in patMuon and patDisplacedMuon with Era Modifier for Run 3.

FYI @CeliaFernandez, @andrea21z. There are some differences in lowptMvaValue and mvaValue

wf 11834.0

patMuons_slimmedMuons__RECO_obj_lowptMvaValue
all_mini_OldVSNew_TTbar14TeVPU2021wf11834p0c_patMuons_slimmedMuons__RECO_obj_lowptMvaValue

patMuons_slimmedMuons__RECO_obj_mvaValue
all_mini_OldVSNew_TTbar14TeVPU2021wf11834p0c_patMuons_slimmedMuons__RECO_obj_mvaValue

@andrea21z
Copy link
Contributor

this PR changes the discriminator to "pfDeepCSVJetTag:probb" in patMuon and patDisplacedMuon with Era Modifier for Run 3.

FYI @CeliaFernandez, @andrea21z. There are some differences in lowptMvaValue and mvaValue

wf 11834.0

patMuons_slimmedMuons__RECO_obj_lowptMvaValue all_mini_OldVSNew_TTbar14TeVPU2021wf11834p0c_patMuons_slimmedMuons__RECO_obj_lowptMvaValue

patMuons_slimmedMuons__RECO_obj_mvaValue all_mini_OldVSNew_TTbar14TeVPU2021wf11834p0c_patMuons_slimmedMuons__RECO_obj_mvaValue

Hi @clacaputo, thank you for informing us. These differences are expected since the b-tagger is an input variable of both MVAs.

@clacaputo
Copy link
Contributor

Hi @andrea21z , thanks for your answer. I'm wondering whether there is a need of re-training from your side, considering that one of the inputs has changed

@clacaputo
Copy link
Contributor

Hi @andrea21z , do we expect a PR from Muon POG, updating the training of the two MVA?

@andrea21z
Copy link
Contributor

Hi @andrea21z , do we expect a PR from Muon POG, updating the training of the two MVA?

Hi @clacaputo, sorry for the delay in answering but we wanted to discuss the status of these two MVA within the Muon POG group first. Right now these MVAs in MiniAOD are not used by any analysis so we believe it is not worth retraining them.

@tvami
Copy link
Contributor

tvami commented Dec 5, 2022

@clacaputo do you have any further questions? Or can this PR be signed from the reco point of view?

@clacaputo
Copy link
Contributor

+reconstruction

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

+1

No changes in Run2 or Run3 nano.

Right now these MVAs in MiniAOD are not used by any analysis so we believe it is not worth retraining them.

@andrea21z if these MVAs are not supported or used anymore, could you consider removing them from miniAOD and/or nanoAOD?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7302937 into cms-sw:master Dec 7, 2022
@tvami
Copy link
Contributor

tvami commented Dec 7, 2022

Right now these MVAs in MiniAOD are not used by any analysis so we believe it is not worth retraining them.

@andrea21z if these MVAs are not supported or used anymore, could you consider removing them from miniAOD and/or nanoAOD?

@swertz maybe this would be a good "github issue" topic?

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

Indeed, done here: https://gitlab.cern.ch/cms-nanoAOD/xpog-coordination/-/issues/46 (we manage XPOG content-related issues there; bugs or issues with the software are still relevant for the CMSSW github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants