Safe Geant4 stacking action

[civanch]

PR description:

There are concerns to Geant4 StackingAction class for handling of CreatorProcess pointer #40090 . This PR intend to fix the issue.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: if will fix the issue then may be considered for the backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40180/33192

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[Dr15Jones]

This does appear to avoid the problem we are seeing with the value from GetCreatorProcess sometimes returning nullptr.

It would still be good if we could track down why the value appears to change within the step action call.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ba467/29341/summary.html
COMMIT: 09e30b7
CMSSW: CMSSW_13_0_X_2022-11-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40180/29341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 59992 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421159
• DQMHistoTests: Total failures: 116103
• DQMHistoTests: Total nulls: 231
• DQMHistoTests: Total successes: 3304803
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.37699999999999995 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.469 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.234 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.229 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.371 KiB SiStrip/MechanicalView
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 15 / 46 workflows

[civanch]

+1

This fix provide smooth running of different IBs, so better to merge. The issue #40090 will be further investigated

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1