[ANALYSIS] [LLVM14] Apply code checks

[smuzaffar]

Applying code checks changes suggested by LLVM 14 ( which we want to integrate in cmssw once fully testing in CLANG IBs).
performance-unnecessary-copy-initialization and readability-container-size-empty checks suggested these modifications.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40194/33212

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40194/33212/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40194/33212/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40194/33228

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• CommonTools/RecoUtils (analysis)
• DPGAnalysis/SiStripTools (analysis)
• PhysicsTools/JetMCAlgos (analysis)
• PhysicsTools/PatExamples (analysis)
• TopQuarkAnalysis/TopKinFitter (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @VourMa, @AlexDeMoor, @AnnikaStein, @robervalwalsh, @JanFSchulte, @VinInn, @missirol, @JyothsnaKomaragiri, @jandrea, @mtosi, @andrzejnovak, @demuller, @threus, @mmusich, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cc496/29367/summary.html
COMMIT: 7435cb2
CMSSW: CMSSW_13_0_X_2022-11-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40194/29367/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421159
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421128
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[perrotta]

merge