Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DB] [LLVM14] Apply code checks #40195

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[DB] [LLVM14] Apply code checks #40195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions CondCore/PhysicsToolsPlugins/interface/DropBoxMetaDataPayloadInspectorHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ namespace DBoxMetadataHelper {
output.push_back(toAppend);
toAppend.clear();
for (unsigned int iPath = 0; iPath < pathsPrep.size(); ++iPath) {
std::string thisString = pathsPrep[iPath];
const std::string& thisString = pathsPrep[iPath];
// skip userText since we want to see actual contents, not metadata
if (thisString.find("userText") == std::string::npos) {
// if the line to be added has less than colWidth chars, and is not a new tag ("inputTag"), append to current
Expand All @@ -260,7 +260,7 @@ namespace DBoxMetadataHelper {
output.push_back(toAppend);
toAppend.clear();
for (unsigned int iPath = 0; iPath < pathsProd.size(); ++iPath) {
std::string thisString = pathsProd[iPath];
const std::string& thisString = pathsProd[iPath];

if (thisString.find("userText") == std::string::npos) {
// if the line to be added has less than colWidth chars append to current
Expand Down Expand Up @@ -614,7 +614,7 @@ namespace DBoxMetadataHelper {
output.push_back("#color[" + std::to_string(color) + "]{" + toAppend + "}");
toAppend.clear();
for (unsigned int iPath = 0; iPath < thePaths.size(); ++iPath) {
std::string thisString = thePaths[iPath];
const std::string& thisString = thePaths[iPath];
// skip userText since we want to compare actual contents, not metadata
if (thisString.find("userText") == std::string::npos) {
// if the line to be added has less than colWidth chars, and is not a new tag ("inputTag"), append to current
Expand Down
2 changes: 1 addition & 1 deletion CondCore/SiPixelPlugins/plugins/SiPixelDynamicInefficiency_PayloadInspector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace {

// constants for ROC level simulation for Phase1
enum shiftEnumerator { FPixRocIdShift = 3, BPixRocIdShift = 6 };
static const int rocIdMaskBits = 0x1F;
const int rocIdMaskBits = 0x1F;

struct packedBadRocFraction {
std::vector<int> badRocNumber;
Expand Down
2 changes: 1 addition & 1 deletion CondFormats/JetMETObjects/src/FactorizedJetCorrectorCalculator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ std::vector<FactorizedJetCorrectorCalculator::VarTypes> FactorizedJetCorrectorCa
const std::vector<std::string>& fNames) const {
std::vector<VarTypes> result;
for (unsigned i = 0; i < fNames.size(); i++) {
std::string ss = fNames[i];
const std::string& ss = fNames[i];
if (ss == "JetPt")
result.push_back(kJetPt);
else if (ss == "JetEta")
Expand Down
2 changes: 1 addition & 1 deletion CondTools/SiStrip/plugins/SiStripBadChannelPatcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void SiStripBadChannelPatcher::fillDescriptions(edm::ConfigurationDescriptions&
unsigned int SiStripBadChannelPatcher::fedFromDetId(const uint32_t& detid) {
// For the cabled det_id retrieve the FEDid
const std::vector<const FedChannelConnection*>& conns = detCabling_->getConnections(detid);
if (!(conns.size())) {
if (conns.empty()) {
edm::LogWarning("SiStripBadChannelPatcher")
<< " DetId " << detid << " appears to be uncabled, returning NOT_A_FEDID !";
return sistrip::NOT_A_FEDID;
Expand Down