Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X] Update Run3 offline and online data GTs #40366

Merged
merged 2 commits into from Dec 20, 2022

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Dec 19, 2022

PR description:

Backport of #40318 and #40367

This PR updates the offline and online data GTs.

Offline GTs updated are (auto:run3_data) and the offline relval GT (auto:run3_data_relval) with:

  • latest conditions to be used for the 2022E Re-Reco (CMSTalk post)
  • updated HCAL QIED conditions requested in (CMSTalk post)
  • Removal of some MVASelector tags for tracking following (CMSTalk post)

For the online data GTs:

  • The HLT and Express frozen GTs have only been updated for the snapshot time.
  • The HLT relval GT has been updated to remove the tag HcalElectronicsMap_full_v2.0_hlt, as requested in this cmsTalk post.
  • The Prompt GT has been updated to include the tag HeavyIonRPRcd_75x_v0_prompt that was added for the Hi test run data-taking, in 124X_dataRun3_Prompt_v10.

GT differences:

Run 3 data (offline)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v14/124X_dataRun3_v11

Run 3 data RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_dataRun3_relval_v6/124X_dataRun3_relval_v12

Diff between new offline and new offline_relval GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v14/124X_dataRun3_relval_v12

run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v8/124X_dataRun3_HLT_frozen_v9

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_relval_v8/124X_dataRun3_HLT_relval_v9

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Express_frozen_v8/124X_dataRun3_Express_frozen_v9

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Prompt_frozen_v7/124X_dataRun3_Prompt_frozen_v8

diff between HLT and HLT_relval GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v9/124X_dataRun3_HLT_relval_v9

PR validation:

runTheMatrix.py -l 139.001 --ibeos -j16

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40318 and #40367

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2022

A new Pull Request was created by @malbouis for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

please test

@malbouis
Copy link
Contributor Author

backport of #40318

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb88ac/29697/summary.html
COMMIT: ec40d46
CMSSW: CMSSW_12_4_X_2022-12-18-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40366/29697/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 199 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 69
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3709215
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 19, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb88ac/29703/summary.html
COMMIT: ec40d46
CMSSW: CMSSW_12_4_X_2022-12-18-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40366/29703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 203 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3709209
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@@ -42,9 +42,9 @@
# GlobalTag for Run3 data relvals (prompt GT) - identical to 124X_dataRun3_Prompt_v5 but with snapshot at 2022-10-04 14:19:51 (UTC)
'run3_data_prompt' : '124X_dataRun3_Prompt_frozen_v5',
# GlobalTag for Run3 offline data reprocessing - snapshot at 2022-11-01 12:00:00 (UTC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: would you like to update also the snapshot time in the comment line (here and below), as you do in the other versions of this PR? (If you want to do so and you only modify the comment lines, I won't retrigger tests and signature, and I'll just merge the PR as it is)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @perrotta , indeed, I forgot to update the comment line. But there is another PR to 124X in the pipeline (to update the online GTs) and I can update the comment lines then, if it is ok with you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malbouis do you mean the backport of #40367?
If so, maybe to speed up you can merge here both updates, and update the comments as weel. Then the two backports could be merged here together by this evening (otherwise to avoid conflicts and rebases you'd have to wait until tomorrow, at least)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would be the backport of #40367
It sounds good. Let me update this PR then now.

@cmsbuild
Copy link
Contributor

Pull request #40366 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@malbouis
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor

Thank you @malbouis
While tests are running, please also update the title of the PR with the online data GTs

@malbouis malbouis changed the title [124X] Update Run3 offline and offline RelVal GTs [124X] Update Run3 offline and online data GTs Dec 20, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb88ac/29716/summary.html
COMMIT: d2d3b34
CMSSW: CMSSW_12_4_X_2022-12-18-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40366/29716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 203 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3709306
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3709209
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 161 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 20, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1f3b9c8 into cms-sw:CMSSW_12_4_X Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants