Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 hcx1 #4050

Merged
merged 1 commit into from Jun 3, 2014
Merged

Phase2 hcx1 #4050

merged 1 commit into from Jun 3, 2014

Conversation

bsunanda
Copy link
Contributor

Safer code

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 hcx1

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Tested all of Sunanda's requests together. Notes on #4079.

cmsbuild added a commit that referenced this pull request Jun 3, 2014
@cmsbuild cmsbuild merged commit 5440902 into cms-sw:CMSSW_6_2_X_SLHC Jun 3, 2014
@mark-grimes mark-grimes mentioned this pull request Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants