Phase2 hgx8

[bsunanda]

Move Shashlik Reco geometry also to FCalGeometry

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 hgx8

It involves the following packages:

Configuration/Geometry
DataFormats/ForwardDetId
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/FCalGeometry
Geometry/HGCalCommonData
RecoParticleFlow/PFClusterProducer

The following packages do not have a category, yet:

DataFormats/ForwardDetId
Geometry/FCalGeometry

@civanch, @nclopezo, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

-1

@bsunanda - I have compilation errors:

In file included from /build/yana/CMSSW_6_2_X_SLHC_2014-06-02-0200/src/Geometry/FCalGeometry/src/ShashlikGeometryBuilderFromDDD.cc:2:0:
/build/yana/CMSSW_6_2_X_SLHC_2014-06-02-0200/poison/Geometry/CaloTopology/interface/ShashlikGeometry.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.

[cmsbuild]

Pull request #4079 was updated. @civanch, @nclopezo, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please check and sign again.

[bsunanda]

Again updated with 4 files - sorry for the slow progress

On Mon, 2 Jun 2014, ianna wrote:

-1

@bsunanda - still have problems with compilation:

In file included from /build/yana/CMSSW_6_2_X_SLHC_2014-06-02-0200/src/Geome
try/CaloEventSetup/plugins/CaloGeometryBuilder.cc:30:0:
/build/yana/CMSSW_6_2_X_SLHC_2014-06-02-0200/poison/Geometry/CaloTopology/in
terface/ShashlikGeometry.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FRO
M THE PACKAGE.

—
Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzMzOT
E1MiwiZGF0YSI6eyJpZCI6MzM2MTc3MTZ9fQ==--3667cf6daa9eec765648094c84993459c8d
8d6bb.gif]

[cmsbuild]

Pull request #4079 was updated. @civanch, @nclopezo, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please check and sign again.

[ianna]

+1

[mark-grimes]

merge

Tested along with #4047, #4050, #4058 and #4073.
Tests 10000, 10200, 10400, 11200, 11400, 12000, 12400, 12800, 13000, 13600, 13800, 14000 and 14600 pass all steps.
Tests 12600 fails in step 2 with known errors.
Tests 12200, 14200 and 14400 fail in step 3 with known errors.