L1T: Add jet quality and eg/tau isolation data vs. emu comparisons and ignore object index [12_6_X]

[bundocka]

Backport of #40511

PR description:

• Adds jet quality and eg/tau isolation to the CaloL2 data vs emulator plots in the online DQM
• Bug fix to ignore the ordering of CaloL2 objects for data vs emulator comparisons

PR validation:

• Ran locally on lxplus with recent ExpressPhysics data and checked histogram outputs are as expected
• Ran unit tests with cmsRun DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py unitTest=True

[cmsbuild]

A new Pull Request was created by @bundocka for CMSSW_12_6_X.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• DQM/L1TMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from L1T: Add jet quality and eg/tau isolation data vs. emu comparisons and ignore object index #40511

[cmsbuild]

Pull request #40512 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bac01e/29998/summary.html
COMMIT: 29bfe55
CMSSW: CMSSW_12_6_X_2023-01-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40512/29998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3458651
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 102
• DQMHistoTests: Total successes: 3458484
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 16.999999999999996 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 0.850 KiB L1TEMU/L1TStage2CaloLayer2
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

hold

• Explicit hold to ensure no accidental merging, the master branch has not converged.

[cmsbuild]

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #40512 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

[emanueleusai]

type l1t

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bac01e/30481/summary.html
COMMIT: 7ed8fed
CMSSW: CMSSW_12_6_X_2023-02-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40512/30481/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460357
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 102
• DQMHistoTests: Total successes: 3460190
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 16.999999999999996 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 0.850 KiB L1TEMU/L1TStage2CaloLayer2
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

unhold

• Signatures have been reset, both here and in the master version L1T: Add jet quality and eg/tau isolation data vs. emu comparisons and ignore object index #40511, of which this PR is a verbatim backport

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[emanueleusai]

@bundocka do you need this deployed online?