Fix BeamSpot Z value in Realistic25ns13p6TeVEOY2022Collision VtxSmearing scenario

[francescobrivio]

PR description:

This is a bug-fix to the Realistic25ns13p6TeVEOY2022Collision VtxSmearing scenario introduced in #40662.

The correct Z position should have been computed as (BeamSpot Z minus BPIX barycenter Z):

-0.2531-(-0.354856) = 0.101756 [cm]

while in the original PR a "-" sign was lost and the Z position was wrongly set to:

0.2531-(-0.354856) = 0.607956 [cm]

This PR fixes the issue by changing:

-    Z0 = cms.double(0.607956)
+    Z0 = cms.double(0.101756)

I profit of this PR to also fix the "missing line at the end of file" as requested in #40662 (comment)

PR validation:

None as nothing is really using this VtxSmearing at the moment.

Backport:

Not a backport - a backport to 13_0_X will be provided in order to have a correct smearing in 13_0_0.

[francescobrivio]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40807/34247

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• IOMC/EventVertexGenerators (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67d55/30717/summary.html
COMMIT: 028b314
CMSSW: CMSSW_13_1_X_2023-02-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40807/30717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 44 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529029
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529004
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1