Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed binary to logical operations in TrackingTools packages #40812

Merged
merged 1 commit into from Feb 20, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

These clear up clang warnings.

PR validation:

Compiling with clang no longer shows the warnings.

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40812/34251

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • TrackingTools/GsfTracking (reconstruction)
  • TrackingTools/TrackFitters (reconstruction)
  • TrackingTools/TrajectoryFiltering (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @jhgoh, @Fedespring, @VourMa, @missirol, @felicepantaleo, @andrea21z, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @HuguesBrun, @ebrondol, @CeliaFernandez, @gpetruc, @mmusich, @trocino, @dgulhan, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b007c8/30722/summary.html
COMMIT: b463013
CMSSW: CMSSW_13_1_X_2023-02-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40812/30722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529004
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction
Technical, just changed bitwise OR to logical OR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Technical PR

@cmsbuild cmsbuild merged commit 01c7544 into cms-sw:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants