Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add double PFTau HLT filter [13_0_X] #40823

Merged
merged 1 commit into from Feb 21, 2023

Conversation

covarell
Copy link
Contributor

PR description:

Just add a new alias for a PFTau-PFTau doublet filter in HLT. Needed for a new W->3pi HLT path.

PR validation:

Just verified scram compilation and used in HLT (no modification of existing code).

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2023

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40823/34278

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@Martin-Grunewald
Copy link
Contributor

Well, you need a PR for the master branch also, before you can do the backport PRs to 130X and 126X.

@Martin-Grunewald
Copy link
Contributor

@smuzaffar
Why does the bot indicate a potential conflict between this PR and #40284 ? The two PRs modify the same file but they are targetting different CMSSW releases, so conflicts do not apply...??

@missirol
Copy link
Contributor

backport of #40824

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3a55/30769/summary.html
COMMIT: 54e5d30
CMSSW: CMSSW_13_0_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40823/30769/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529000
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

@covarell , just for clarity, can you please add "HLT" and "13_0_X" to the PR title? e.g. "add double PFTau HLT filter [13_0_X]"

@missirol
Copy link
Contributor

+hlt

  • addition of a new HLT filter, not currently used in any central wfs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@covarell covarell changed the title add double PFTau filter add double PFTau HLT filter [13_0_X] Feb 21, 2023
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ba3568 into cms-sw:CMSSW_13_0_X Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants