Make sure variables are preserved in ReggeGribovPartonMCInterface

[Dr15Jones]

PR description:

The compiler had warnings about possibly uninitialized values in the FORTRAN. Looking at the algorithm, the code expects the subroutine values to be preserved between calls. The portable way of doing that is to use the save keyword.

One of the previous uninitialized fixes incorrectly reset the value of an array each call rather than using save which is needed for the algorithm to properly work.

PR validation:

The code compiles. As the warning was in the aarch64 build and I do not have access to that machine, it is unclear if the warning will go away.

[Dr15Jones]

please test

[Dr15Jones]

@makortel FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40962/34462

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• GeneratorInterface/ReggeGribovPartonMCInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test for el8_aarch64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2910a/31093/summary.html
COMMIT: 57c754a
CMSSW: CMSSW_13_1_X_2023-03-05-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40962/31093/install.sh to create a dev area with all the needed externals and cmssw changes.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2910a/31092/summary.html
COMMIT: 57c754a
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40962/31092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529727
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529702
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@cms-sw/generators-l2 ping

[Dr15Jones]

ping @cms-sw/generators-l2

[Dr15Jones]

ping @cms-sw/generators-l2

[Saptaparna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1