Add vertex of problem tau in HepMCValidationHelper

[Dr15Jones]

PR description:

It is possible that the tau has gone farther than the generator is willing to decay it.

PR validation:

Code compiles.

[Dr15Jones]

please test

[Dr15Jones]

@makortel FYI

[Dr15Jones]

Another possible issue is the tau comes after the pruning happens to the particle list. Perhaps the pruning removed the daughters?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40964/34464

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• Validation/EventGenerator (dqm, generators)

@SiewYan, @mkirsano, @emanueleusai, @GurpreetSinghChahal, @Saptaparna, @alberto-sanchez, @syuvivida, @menglu21, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

Would the production vertex be useful as well?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec479d/31105/summary.html
COMMIT: 57ba8dc
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40964/31105/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529727
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529698
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test

[Dr15Jones]

@makortel

Would the production vertex be useful as well?

The belief is the decay is beyond the beam pipe cutoff limit so the only important value is the decay vertex. Also, since this comes from the generator and the generator is not supposed to decay 'long flying' particles the production vertex should be close to the beam interaction point.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40964/34486

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #40964 was updated. @SiewYan, @mkirsano, @emanueleusai, @GurpreetSinghChahal, @Saptaparna, @alberto-sanchez, @syuvivida, @menglu21, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec479d/31125/summary.html
COMMIT: a22109f
CMSSW: CMSSW_13_1_X_2023-03-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40964/31125/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529727
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529701
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@cms-sw/generators-l2 @cms-sw/dqm-l2 please consider signing as the change is trivial and should help crackdown the ongoing problem.

[emanueleusai]

+1

[Dr15Jones]

@cms-sw/generators-l2 ping

[Dr15Jones]

@cms-sw/generators-l2 ping

[Dr15Jones]

@cms-sw/generators-l2 the failure this PR is meant to help diagnosed has happened 4 times this week in the IBs. Having this change in will help trace down the origin of the problem.

[perrotta]

+1

• This only updates the Exception message: let bypass the @cms-sw/generators-l2 signature (but please feel free to comment and complain once this is merged)

[perrotta]

merge