Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixelDynamicInefficiency_PayloadInspector fix issue with PU parametrization plot polynomial representation #40981

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 7, 2023

PR description:

Attempt to fix the issue described at CMSTrackerDPG/Tasks#1 (comment) .
It looks like that when the library is loaded from cvmfs instead that local installation, the very same plot that in local renders fine gets screwed up.
Added also some debug statement that were useful to address CMSTrackerDPG/Tasks#1 (comment)

PR validation:

Run private tests:

setenv SCRAM_ARCH el8_amd64_gcc11
cmsrel CMSSW_13_1_X_2023-03-06-2300
cd CMSSW_13_1_X_2023-03-06-2300/src
git cms-addpkg CondCore/SiPixelPlugins
scram b -j 20
getPayloadData.py --plugin pluginSiPixelDynamicInefficiency_PayloadInspector --plot plot_SiPixelDynamicInefficiencyPUParametrization --tag SiPixelDynamicInefficiency_phase1_2023_v1_fix --time_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --db Prod --test 

Also I tested that in a local installation in CMSSSW_13_1_0_pre1 in which the problem appeared, it went away, although I cannot be fully certain that this works fine until there is a pre-release with this included.
Apparently there is a standing issue in using IBs in the central Payload Inspector web-service, see https://its.cern.ch/jira/browse/CMSDBBROWS-134

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Mar 7, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40981/34483

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/SiPixelPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 7, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0164f/31122/summary.html
COMMIT: f2c6ad9
CMSSW: CMSSW_13_1_X_2023-03-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40981/31122/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 24 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529727
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 7, 2023

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 7, 2023

+1

@cmsbuild cmsbuild merged commit 085e156 into cms-sw:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants