Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatPU #4102

Merged
merged 3 commits into from Jun 19, 2014
Merged

FlatPU #4102

merged 3 commits into from Jun 19, 2014

Conversation

tomcornelis
Copy link
Contributor

Also pull request for CMSSW_7_0_X branch

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_7_0_X.

FlatPU

It involves the following packages:

Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

-1
I found an error when building:

Compiling src/SimGeneral/MixingModule/python/mix_flat_0_10_cfi.py ...
Sorry: IndentationError: ('unexpected indent', ('src/SimGeneral/MixingModule/python/mix_flat_0_10_cfi.py', 49, 4, '    mixObjects = cms.PSet(theMixObjects)\n'))
gmake[1]: **\* [CompilePython] Error 1
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_0_X-slc6_amd64_gcc481/CMSSW_7_0_X_2014-06-03-0200'
gmake: **\* [src] Error 2
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4102/187/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

Pull request #4102 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2014

@tomcornelis
Copy link
Contributor Author

Could this pull request be signed, so that it could go into the next CMSSW_7_0_X release? We need this PU scenario soon.

@srimanob
Copy link
Contributor

@davidlange6
I forgot to ask this in the ORP. The additional PU scenario is needed, so we need to have it in 7_0_6.

Thanks,
Phat

@tomcornelis tomcornelis mentioned this pull request Jun 17, 2014
@davidlange6
Copy link
Contributor

trivial - so bypassing..

davidlange6 added a commit that referenced this pull request Jun 19, 2014
@davidlange6 davidlange6 merged commit 4c8fd2d into cms-sw:CMSSW_7_0_X Jun 19, 2014
ktf added a commit to ktf/cmssw that referenced this pull request Jun 19, 2014
This was referenced Jun 19, 2014
@tomcornelis tomcornelis deleted the patch-3 branch April 13, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants