Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the naming convention of CaloMETs #4114

Merged
merged 5 commits into from Jun 12, 2014

Conversation

TaiSakuma
Copy link
Contributor

Continuing from #3942, this PR still changes the naming convention of CaloMETs.

In particular, this PR adds the definition of caloMetM, which is to replace corMetGlobalMuons.

This change was originally planned for CMSSW_7_1_0 but hasn't been implemented.

We announced this change at the JMAR meeting on 24-Apr-2014:
https://indico.cern.ch/event/304145/contribution/0

We discussed this change at the RECO meeting on 17-Apr-2014: https://indico.cern.ch/event/313948/contribution/18

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2014

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X.

change the naming convention of CaloMETs

It involves the following packages:

RecoMET/METProducers

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@TaiSakuma
Copy link
Contributor Author

I added to RECO and AOD caloMetM, which is to replace corMetGlobalMuons.

corMetGlobalMuons is used in several places in CMSSW.
http://cmslxr.fnal.gov/lxr/search?v=CMSSW_7_1_0_pre8;string=corMetGlobalMuons
I will replace them with caloMetM.

After the replacement is finished, I will delete corMetGlobalMuons from RECO, AOD, and the RECO sequence.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2014

Pull request #4114 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

@TaiSakuma
Copy link
Contributor Author

@cmsbuild, the test has been running for two days. isn't it taking too long?

@davidlange6
Copy link
Contributor

there is a backlog of tests right now..

On Jun 7, 2014, at 4:00 PM, Tai Sakuma notifications@github.com
wrote:

@cmsbuild, the test has been running for two days. isn't it taking too long?


Reply to this email directly or view it on GitHub.

@slava77
Copy link
Contributor

slava77 commented Jun 12, 2014

+1

for #4114 1a9acf8
runs ok, the collection appears in the output

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 12, 2014
Change the naming convention of CaloMETs
@ktf ktf merged commit 8037e56 into cms-sw:CMSSW_7_2_X Jun 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants