Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global muon refitter and TrackTransformer #4179

Merged
merged 2 commits into from Jun 15, 2014

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jun 10, 2014

as reported by Andrea Giammanco

tested with

cd CMSSW_7_1_0_pre9/src
git cms-addpkg FastSimulation/Configuration
scram b -j 8
edit FastSimulation/Configuration/python/CommonInputs_cff.py and set MixingMode = 'DigiRecoMixing' instead of 'GenMixing'

cmsDriver.py SingleMuPt10_cfi.py -s GEN,SIM,RECO --fast --pileup=mix_2012_Summer_inTimeOnly --conditions auto:startup_GRun --beamspot Realistic8TeVCollision --eventcontent=FEVTDEBUGHLT --datatier GEN-SIM-DIGI-RECO -n 10

@VinInn VinInn changed the title Global muon refitter Global muon refitter and TrackTransformer Jun 10, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_1_X.

Global muon refitter and TrackTransformer

It involves the following packages:

RecoMuon/GlobalTrackingTools
TrackingTools/TrackRefitter

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @rociovilar, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@giamman
Copy link
Contributor

giamman commented Jun 10, 2014

Hi all,
I just re-tested this PR, also looking at the physics correctness of a very small single-muon sample. I would say that everything is ok.

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2014

Hi Andrea
this is essential for 71X, right?

@giamman
Copy link
Contributor

giamman commented Jun 10, 2014

Hi Slava, I would answer yes but I am quite biased. And I don't know what the L1 management thinks about that.
Now that this PR is in, I can produce a new PR, dependent on this one, with a workflow to create a new FastSim-specific official MinBias sample needed for validation, and the workflow that will use that. In any case, coordination will be needed with PdmV in order to actually produce the new MinBias sample, etc. (My plan was to ping the PdmV conveners as soon as my PR will be on github.)
Certainly, the earlier we can start this step, the more time will be saved later. But I will let @davidlange6 comment about that.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

i don't have any problem fixing bugs in 71x… hard for me to judge this small change if its in some way complex.

@giamman
Copy link
Contributor

giamman commented Jun 12, 2014

Thanks!

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

+1

for #4179 610ceb9
tested in CMSSW_7_1_X_2014-06-12-0200 (test area sign710a)

everything is OK: no diffs, timing is the same within normal jitter

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 15, 2014
Global muon refitter and TrackTransformer
@davidlange6 davidlange6 merged commit ab1ec71 into cms-sw:CMSSW_7_1_X Jun 15, 2014
@ktf ktf mentioned this pull request Jun 23, 2014
@VinInn VinInn deleted the GlobalMuonRefitter branch April 21, 2017 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants