Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniAOD part 4 (7.0.X) #4204

Merged
merged 11 commits into from Jun 19, 2014
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Jun 11, 2014

Updates to miniAOD for the Taus, for CSA14.

After this, the only missing piece for the final 7.0.X is a few lines change in PhysicsTools/PatAlgos to use ak4PFchs JECs, but for that we still need from JetMET the new global: when it comes, I can either add it to this PR or make a new one, depends what you prefer

A separate request for 7.1.X and 7.2.X will be made, put please start with integrating this one for CSA: in fact, it could be even easier for us then to make the 7.1.X and 7.2.X PRs on top of the auto-forward-port of this, avoiding the issues we had on integrating part3 in 7.0.X

cmsDriver workflows tested:

cmsDriver.py miniAOD_data-prod -s PAT -n 100 --data --filein /store/relval/CMSSW_7_0_0/SingleMu/RECO/GR_R_70_V1_RelVal_zMu2012D-v2/00000/0259E46E-F698-E311-8CFD-003048FF9AC6.root  --eventcontent MINIAOD --runUnscheduled --conditions GR_R_70_V1::All --no_exec
cmsDriver.py miniAOD-prod -s PAT -n 100 --mc --filein /store/relval/CMSSW_7_0_0/RelValTTbar_13/GEN-SIM-RECO/PU50ns_POSTLS170_V4-v2/00000/265B9219-FF98-E311-BF4A-02163E00EA95.root  --eventcontent MINIAODSIM --runUnscheduled --conditions auto:startup --no_exec
cmsDriver.py miniAOD-fsim-prod -s PAT -n 100 --mc --fast --filein /store/relval/CMSSW_7_0_0/RelValTTbar_13/GEN-SIM-DIGI-RECO/POSTLS170_V3_FastSim-v2/00000/109B6DF8-A798-E311-A88F-02163E00A0F0.root --eventcontent MINIAODSIM --runUnscheduled --conditions POSTLS170_V3::All --no_exec

@jpavel @arizzi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_0_X.

miniAOD part 4 (7.0.X)

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1

Tested at: 6e1533c
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4204/195/summary.html

@cmsbuild
Copy link
Contributor

@arizzi
Copy link
Contributor

arizzi commented Jun 13, 2014

Unit tests are failing because they run on 700pre11 input files rather than full 70X input files. The missing product it complains about has been added in pre13.
@vadler can you update python/patInputFiles_cff.py ?

@gpetruc
Copy link
Contributor Author

gpetruc commented Jun 13, 2014

Added a commit from @arizzi that improves the event size in pythia8

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2014

I see that new code in RECO packages is already in 72X, which is good (no fw porting needed).
Changes in PAT (esp Tau data formats) are unique to this PR (not in 72X), will they stay here or will there be some forward porting?

@gpetruc
Copy link
Contributor Author

gpetruc commented Jun 17, 2014

For many things the auto forward port should work, but there's some things
we might want to revise in 7.2.X once we get a bit of time (finishing the
7.0.X was the highest priority in order to have something to start CSA14
with)

     Giovanni

On Tue, Jun 17, 2014 at 9:03 PM, Slava Krutelyov notifications@github.com
wrote:

I see that new code in RECO packages is already in 72X, which is good (no
fw porting needed).
Changes in PAT (esp Tau data formats) are unique to this PR (not in 72X),
will they stay here or will there be some forward porting?


Reply to this email directly or view it on GitHub
#4204 (comment).

@slava77
Copy link
Contributor

slava77 commented Jun 18, 2014

+1

for #4204 e333ff7

checked in CMSSW_7_0_X_2014-06-17-1400

code changes are not relevant to RECO standard sequences

@davidlange6
Copy link
Contributor

@montjj - please bring up any issues from the AT side in the next 24 hours. Thanks

@arizzi
Copy link
Contributor

arizzi commented Jun 18, 2014

I guess it was for @monttj

@monttj
Copy link
Contributor

monttj commented Jun 19, 2014

+1
I am sorry for late response. I was traveling to CERN.
There is no issue from the AT side.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 19, 2014
@davidlange6 davidlange6 merged commit bf9bba2 into cms-sw:CMSSW_7_0_X Jun 19, 2014
ktf added a commit to ktf/cmssw that referenced this pull request Jun 19, 2014
Conflicts:
	DataFormats/PatCandidates/src/classes_def_objects.xml
This was referenced Jun 19, 2014
@gpetruc gpetruc deleted the miniAOD-from704-part4 branch September 30, 2015 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants