Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and modifications on GEM TnP efficiency plots (backport of #42639, 13_0_X) #42685

Merged
merged 2 commits into from Sep 8, 2023

Conversation

jo100sun
Copy link
Contributor

PR description:

Backport of (#42639)[https://github.com//pull/42639]. This PR introduces updates on GEM TnP efficiency plots and bugfix for the GEM edge distance calculation at TrackerMuon propagation. (#40554)[https://github.com//pull/40554]

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is backport of (#42639)[https://github.com//pull/42639]. We would like to introduce this changes for upcoming run.

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jo100sun (jo100) for CMSSW_13_0_X.

It involves the following packages:

  • DQMOffline/MuonDPG (dqm)
  • TrackingTools/TrackAssociator (reconstruction)

@nothingface0, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @andrea21z, @JanFSchulte, @jhgoh, @missirol, @HuguesBrun, @ptcox, @trocino, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @Fedespring, @calderona, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #42685 was updated. @nothingface0, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

@mandrenguyen
Copy link
Contributor

type muon, bug-fix

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e012f8/34576/summary.html
COMMIT: 69b820f
CMSSW: CMSSW_13_0_X_2023-09-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42685/34576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 33 lines to the logs
  • Reco comparison results: 204 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3282889
  • DQMHistoTests: Total failures: 1031
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281836
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 94.41599999999997 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 5.901 KiB GEM/Segment_TnP
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

@cms-sw/dqm-l2 is this okay to sign for 13_0?

@emanueleusai
Copy link
Member

+1

  • tests at P5 ok
  • DQM differences in Muon plots as expected
  • DQM differences in 12434.7 not related to this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a52fd13 into cms-sw:CMSSW_13_0_X Sep 8, 2023
10 checks passed
@jo100sun
Copy link
Contributor Author

Hello @emanueleusai , can you tell me when this PR will be available to see at cmsweb?

@syuvivida
Copy link
Contributor

Hi @jo100sun as you know the HI data will be processed with 13_2_X. Do you need these plots to be fixed/displayed for HI runs? I see #42687 is merged but not yet included in 13_2_3 (current version run at Tier-0). If yes, we need to ask to build a new release to include this PR.

@jo100sun
Copy link
Contributor Author

jo100sun commented Sep 19, 2023

Do you need these plots to be fixed/displayed for HI runs?

Yes exactly. I saw my changes are included in 13_2_4. Will this change apply to DQM also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants