Correct v5 version of HGCal geometry

[bsunanda]

Similar to Phase2-hgx15 but remade with last night's IB

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Correct v5 version of HGCal geometry

It involves the following packages:

Geometry/HGCalCommonData
Validation/CheckOverlap

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

[mark-grimes]

The crash in 142xx is back:

#5  0x00002abfe30f8e75 in CaloCellGeometry::operator=(CaloCellGeometry const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-22-0200/lib/slc5_amd64_gcc472/libGeometryCaloGeometry.so
#6  0x00002abfe3100871 in FlatTrd::operator=(FlatTrd const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-22-0200/lib/slc5_amd64_gcc472/libGeometryCaloGeometry.so
#7  0x00002abfe5a9af54 in HGCalGeometry::newCell(Point3DBase<float, GlobalTag> const&, Point3DBase<float, GlobalTag> const&, Point3DBase<float, GlobalTag> const&, float const*, DetId const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-22-0200/lib/slc5_amd64_gcc472/libGeometryFCalGeometry.so
#8  0x00002abfe5a9bc2b in HGCalGeometryLoader::build(HGCalTopology const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-22-0200/lib/slc5_amd64_gcc472/libGeometryFCalGeometry.so
#9  0x00002abfe5a8bb97 in HGCalGeometryESProducer::produce(IdealGeometryRecord const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-06-22-0200/lib/slc5_amd64_gcc472/pluginGeometryFCalGeometryPlugins.so

@bsunanda, this was fixed in your other request (I think) #4231. I'll see if I can find what the difference is, if you know modify the pull request.

[mark-grimes]

Looking at the diffs it appears this pull request reverts the changes made by #4231 to the xml geometry files. Was that intentional? I've re-applied #4231 on top and put in a new pull request #4358. @bsunanda could you check that? If this was intentional let me know and I'll close #4358.

[bsunanda]

Hi

The pull request #4313 should change xml files for all HGCal related ones
in HGCalCommonData. I forgot the changes in #4231. I shall take a look at
#4358 vs #4313 and let you know. Cheers Sunanda

On Mon, 23 Jun 2014, Mark Grimes wrote:

Looking at the diffs it appears this pull request reverts the changes made
by #4231 to the xml geometry files. Was that intentional? I've re-applied
#4231 on top and put in a new pull request #4358. @bsunanda could you check
that? If this was intentional let me know and I'll close #4358.

—
Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTE1OT
MwMCwiZGF0YSI6eyJpZCI6MzUwNDcyOTZ9fQ==--db986b1f481abaa310ecdff2198fdb46880
4028c.gif]

[bsunanda]

Hi Mark

The new pull request #4358 is the right one. I am clising #4313. Since I
started with Valery's branch I forgot the fixes I made in v1..v3. I shall
also make the last changes in pull request 4340 on top of 4358. Cheers

Sunanda

On Mon, 23 Jun 2014, Mark Grimes wrote:

Looking at the diffs it appears this pull request reverts the changes made
by #4231 to the xml geometry files. Was that intentional? I've re-applied
#4231 on top and put in a new pull request #4358. @bsunanda could you check
that? If this was intentional let me know and I'll close #4358.

—
Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTE1OT
MwMCwiZGF0YSI6eyJpZCI6MzUwNDcyOTZ9fQ==--db986b1f481abaa310ecdff2198fdb46880
4028c.gif]