70 x hcal pre mix bugfix #4325
Merged
70 x hcal pre mix bugfix #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
A new Pull Request was created by @mdhildreth for CMSSW_7_0_X. 70 x hcal pre mix bugfix It involves the following packages: EventFilter/HcalRawToDigi @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
Merged
ktf
added a commit
to ktf/cmssw
that referenced
this pull request
Jun 20, 2014
Merged
This was referenced Jun 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications for Hcal PreMixing. Technically, digitization is not done; the scaled fC values are passed directly and reconstituted. This removes any digitization noise. Overflows are handled by setting the error bit on that sample (note bugfix to the HcalPacker to allow this!) and then using the "standard" adc->fC conversion for these values.