Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericMVAComputerCache bug fix #4452

Merged
merged 1 commit into from Jul 3, 2014
Merged

GenericMVAComputerCache bug fix #4452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoBTau/JetTagComputer/interface/GenericMVAComputerCache.h
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ class GenericMVAComputerCache {

GenericMVAComputer const* getComputer(int index) const;

inline bool isEmpty() const;
bool isEmpty() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the intention was for the function to be inline. Just checking explicitly you don't want it inline anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want it to be inline anymore. I don't know the technical details, @wddgit can tell you more if needed.


private:
struct IndividualComputer {
Expand Down