Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inheritance check for non-class types #4459

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 30, 2014

The TypeWithDict class (our replacement for Reflex::Type) has checks to see if one type inherits from another type. Currently, these checks will throw an exception if one or both of the types in question is not a class. The check should be more general. This pull request changes the check for inheritance to simply return false if one or both of the types is not a class.
Please merge promptly unless there are issues.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X.

Allow inheritance check for non-class types

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Jun 30, 2014
Allow inheritance check for non-class types
@davidlt davidlt merged commit 2b8f04a into cms-sw:CMSSW_7_2_ROOT6_X Jun 30, 2014
@wmtan wmtan deleted the AllowInheritanceCheckForNonClasses branch June 30, 2014 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants