Adding hooks to tau sequence to read from DB

[jpavel]

• restoring PhysicsTFormulaPayload and PhysicsTGraphPayload plugins deleted in earlier release
• adding interfaces to tau MVA discriminators to be able to read also from the sqlite
• adding a master python switch that makes all relevant discriminators read from sqlite instead of local root file

These pre-requsites are necessary for the tau payloads to be moved to CondDB. This PR does not change default RECO at all, only adds possibility to run with different input that is turned off by default.

[cmsbuild]

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_2_X.

Adding hooks to tau sequence to read from DB

It involves the following packages:

CondCore/PhysicsToolsPlugins
RecoTauTag/Configuration
RecoTauTag/RecoTau

@apfeiffer1, @nclopezo, @cmsbuild, @StoyanStoynev, @slava77, @ggovi, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[jpavel]

just out of curiosity, any chance this one makes it to 720_pre2? It would allow us to upload payloads to the database. Otherwise we will need to wait for the next pre-release

[StoyanStoynev]

I am to start extended tests for it and look at the code today but we need the jenkins tests too.

[jpavel]

thanks Stoyan!

[slava77]

pre2 is out already (not announced yet)

[davidlange6]

Actually, it is not out yet given troubles with various things

On Jul 10, 2014, at 10:12 AM, Slava Krutelyov notifications@github.com
wrote:

pre2 is out already (not announced yet)

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

-1
Tested at: 247ff14
When I ran the RelVals I found an error in the following worklfows:
1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 10-Jul-2014 10:15:16 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23623846
   [1] Running path 'tcPath'
   [2] Calling event method for module CandViewSelector/'tcMETSelector'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: tcMet
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4585/308/summary.html

[jpavel]

Isn't it problem of a relval? This PR was running fine in CMSSW_7_2_X_2014-07-09-0200

[ghost]

Yes, it is.

[StoyanStoynev]

Then can we have the jenkins/comparisons to a previous IB (like CMSSW_7_2_X_2014-07-09-0200 above or *-1400)? As Slava pointed to me CMSSW_7_2_X_2014-07-10-0200 has build errors so it should not be used for comparisons anyway: https://cmssdt.cern.ch/SDT/jenkins-artifacts/summary-merged-prs/merged_prs.html

[StoyanStoynev]

@jpavel I see somedifferences in MVA electron rejection variables:

.
Differences come at high eta:

Seen in hpsPFTauDiscriminationByMVA5*ElectronRejection with * -> Loose, Medium, Tight, VTight.
The figures are from wf 202 (ttbar with PU) and wf 38 (QCD) show consistent results. In wf 38 though differences are also found in hpsPFTauDiscriminationByMediumIsolationMVA3oldDMwLT hpsPFTauDiscriminationByVLooseIsolationMVA3oldDMwLT.
What would you say about these?

[StoyanStoynev]

a small correction : hpsPFTauDiscriminationByVLooseIsolationMVA3oldDMwLT -> hpsPFTauDiscriminationByVLooseIsolationMVA3newDMwLT

[StoyanStoynev]

What is the expected effect of this change?

[jpavel]

It should reconstruct the primary vertex for more taus, probably affecting the lifetime discriminators. I think we can revert this change for the time being.

[jpavel]

Thanks for having a look - those changes are indeed not expected. I was the only author, so let me check the pieces written by Christian

[jpavel]

So I reverted the only piece of code which should have changed something - the rest is cosmetics.

[cmsbuild]

Pull request #4585 was updated. @ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please check and sign again.

[StoyanStoynev]

Sounds good. What is left looks trivial but I'll make the complete tests
given there is something we didn't understand (moreover jenkins will not run before 72X is fixed as I understood; my tests will also suffer a bit but not in a crucial way).

[StoyanStoynev]

Actually my signature is not needed anymore. Just for completeness - no differences are observed with the updated PR in the extended matrix tests (and none expected with the trivial now code updates).

[cmsbuild]

+1
Tested at: 2f76dd6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4585/317/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4585/317/summary.html

[jpavel]

@ggovi, @apfeiffer1, @Degano, @nclopezo can you please have a look and sign? It will be VERY appreciated if we can get this update to 720_pre2 and so to CondDB SW

[apfeiffer1]

+1
sorry for being late with this ... :(

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).