-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle Flow for HGC -- for SLHC16 #4632
Particle Flow for HGC -- for SLHC16 #4632
Conversation
Complete technical part of SimHit Validation for Shashlik
binary pixel readout for barrel gt 4 or endcap gt 10
Small adjustments for the AM tutorial
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC. Particle Flow for HGC -- for SLHC16 It involves the following packages: Configuration/Geometry The following packages do not have a category, yet: Geometry/FCalGeometry @civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @alja, @nclopezo, @StoyanStoynev, @slava77, @Degano, @ktf can you please review it and eventually sign? Thanks. |
+1 haven't reviewed in detail, but FastSim changes look reasonable |
merge All tests pass fine. No idea why the diff here says 116 files - when merged it's only 33 and all ParticleFlow packages (or ParticleFlow DataFormats packages etcetera); or FastSim which has been approved. Modification to the customisation too which I'm happy with. |
@mark-grimes Github is weird won't update the diff on the webpage relative to the code moving underneath it, from what I can tell. Oh never mind, I see what happened, it did update with respect to the code underneath and the merge to the other PRs brought some older commits it... A bit confusing... |
Particle Flow for HGC -- for SLHC16
This PR contains a preliminary version of particle flow that includes the HGC.
Charged/neutral hadrons and photons are now reconstructed in the HGCal, but many details need to be filled in. Track-cluster linking is in place in this version so charged pions can be studied and refined.
This PR includes #4551 from @pfs, but should merge properly if #4551 goes in first.
Barring any problems that the present testing (min bias, simple jet gun, pion gun, electrons, pi0s) hasn't found, this should go in SLHC16.
@vandreev11 @pfs @amagnan