Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Flow for HGC -- for SLHC16 #4632

Merged
merged 33 commits into from
Jul 15, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 12, 2014

This PR contains a preliminary version of particle flow that includes the HGC.
Charged/neutral hadrons and photons are now reconstructed in the HGCal, but many details need to be filled in. Track-cluster linking is in place in this version so charged pions can be studied and refined.

This PR includes #4551 from @pfs, but should merge properly if #4551 goes in first.

Barring any problems that the present testing (min bias, simple jet gun, pion gun, electrons, pi0s) hasn't found, this should go in SLHC16.

@vandreev11 @pfs @amagnan

Sunanda and others added 30 commits June 28, 2014 12:29
Complete technical part of SimHit Validation for Shashlik
binary pixel readout for barrel gt 4 or endcap gt 10
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Particle Flow for HGC -- for SLHC16

It involves the following packages:

Configuration/Geometry
DataFormats/ParticleFlowReco
FastSimulation/BaseParticlePropagator
Fireworks/Geometry
Geometry/CMSCommonData
Geometry/FCalGeometry
Geometry/HGCalSimData
RecoLocalCalo/HGCalRecProducers
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HGCSimProducers
SimGeneral/MixingModule

The following packages do not have a category, yet:

Geometry/FCalGeometry
Geometry/HGCalSimData
RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCSimProducers

@civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @alja, @nclopezo, @StoyanStoynev, @slava77, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @alja, @bachtis, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

haven't reviewed in detail, but FastSim changes look reasonable

@mark-grimes
Copy link

merge

All tests pass fine. No idea why the diff here says 116 files - when merged it's only 33 and all ParticleFlow packages (or ParticleFlow DataFormats packages etcetera); or FastSim which has been approved. Modification to the customisation too which I'm happy with.

@lgray
Copy link
Contributor Author

lgray commented Jul 15, 2014

@mark-grimes Github is weird won't update the diff on the webpage relative to the code moving underneath it, from what I can tell. Oh never mind, I see what happened, it did update with respect to the code underneath and the merge to the other PRs brought some older commits it... A bit confusing...

cmsbuild added a commit that referenced this pull request Jul 15, 2014
Particle Flow for HGC --  for SLHC16
@cmsbuild cmsbuild merged commit a9fd037 into cms-sw:CMSSW_6_2_X_SLHC Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants