Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test input files for MET packages #4713

Merged
merged 3 commits into from Jul 25, 2014

Conversation

TaiSakuma
Copy link
Contributor

This PR updates the test input files in RecoMET/METProducers and JetMETCorrections/Type1MET.

The previous updates were made at #3965 for RecoMET/METProducers and at #4283 for JetMETCorrections/Type1MET.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X.

update test input files for MET packages

It involves the following packages:

JetMETCorrections/Type1MET
RecoMET/METProducers

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2014

@cmsbuild @Degano @nclopezo (Alessandro or David)
There are too many changes in jenkins output. This doesn't make sense for the code changes in this PR.
Could you please rerun the test

@nclopezo
Copy link
Contributor

Hi Slava,
The tests are running

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 25, 2014

+1

for #4713 694de84
this fixes a problem in #4709 unit test

ktf added a commit that referenced this pull request Jul 25, 2014
Update test input files for MET packages
@ktf ktf merged commit e372e64 into cms-sw:CMSSW_7_2_X Jul 25, 2014
@ktf
Copy link
Contributor

ktf commented Jul 25, 2014

Bypassing AT since currently broken. Complain if not ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants