Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add grooming parameters for fastjet #4733

Merged
merged 2 commits into from Jul 24, 2014
Merged

Feature/add grooming parameters for fastjet #4733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b6f37
added parameters for jet grooming
clint-richardson Jul 22, 2014
253fee1
changed to read in value of grooming parameter
clint-richardson Jul 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions RecoJets/JetProducers/plugins/FastjetJetProducer.cc
View file
Open in desktop
Expand Up @@ -123,25 +123,25 @@ FastjetJetProducer::FastjetJetProducer(const edm::ParameterSet& iConfig)
useExplicitGhosts_ = true;

if ( iConfig.exists("useMassDropTagger") ) {
useMassDropTagger_ = true;
useMassDropTagger_ = iConfig.getParameter<bool>("useMassDropTagger");
muCut_ = iConfig.getParameter<double>("muCut");
yCut_ = iConfig.getParameter<double>("yCut");
}

if ( iConfig.exists("useFiltering") ) {
useFiltering_ = true;
useFiltering_ = iConfig.getParameter<bool>("useFiltering");
rFilt_ = iConfig.getParameter<double>("rFilt");
nFilt_ = iConfig.getParameter<int>("nFilt");
}

if ( iConfig.exists("useTrimming") ) {
useTrimming_ = true;
useTrimming_ = iConfig.getParameter<bool>("useTrimming");
rFilt_ = iConfig.getParameter<double>("rFilt");
trimPtFracMin_ = iConfig.getParameter<double>("trimPtFracMin");
}

if ( iConfig.exists("usePruning") ) {
usePruning_ = true;
usePruning_ = iConfig.getParameter<bool>("usePruning");
zCut_ = iConfig.getParameter<double>("zcut");
RcutFactor_ = iConfig.getParameter<double>("rcut_factor");
nFilt_ = iConfig.getParameter<int>("nFilt");
Expand Down
22 changes: 21 additions & 1 deletion RecoJets/JetProducers/python/hltak5CaloJets_cfi.py
View file
Open in desktop
Expand Up @@ -37,5 +37,25 @@
MaxVtxZ = cms.double(15.0),
src = cms.InputTag("hltTowerMakerForAll"),
subtractorName = cms.string(""),
sumRecHits = cms.bool(False)
sumRecHits = cms.bool(False),
useMassDropTagger = cms.bool(False),
useCMSBoostedTauSeedingAlgorithm = cms.bool(False),
muCut = cms.double(-1.0),
yCut = cms.double(-1.0),
useFiltering = cms.bool(False),
rFilt = cms.double(-1.0),
nFilt = cms.int(-1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Likewise here:

You added two parameters as cms.int(). This type does not exist.
You need to add it as cms.int32(.).
Please submit a new backport PR to correct this.
You can check for such errors by running

python hltak5CaloJets_cfi.py

useTrimming = cms.bool(False),
trimPtFracMin = cms.double(-1.0),
usePruning = cms.bool(False),
zcut = cms.double(-1.0),
rcut_factor = cms.double(-1.0),
muMin = cms.double(-1.0),
muMax = cms.double(-1.0),
yMin = cms.double(-1.0),
yMax = cms.double(-1.0),
dRMin = cms.double(-1.0),
dRmax = cms.double(-1.0),
maxDepth = cms.int(-1),
subjetPtMin = cms.dobule(-1.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise here: double instead of dobule.

@ktf
Why are those errors in cfi not caught and flagged by scram?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add this parameter

puPtMin = cms.double(10.0)

)