Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add grooming parameters for fastjet #4733

Merged
merged 2 commits into from Jul 24, 2014
Merged

Feature/add grooming parameters for fastjet #4733

merged 2 commits into from Jul 24, 2014

Conversation

clint-richardson
Copy link
Contributor

this is a backport to 71X for git PR 4705. It adds needed grooming parameters to an hlt cfi.py file and modifies the fastjetjetproducer module to read in values of the parameters as opposed to just checking for their existence.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @clint-richardson (Clint Richardson) for CMSSW_7_1_X.

Feature/add grooming parameters for fastjet

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

This is a backport of #4705 .

@cmsbuild
Copy link
Contributor

+1
Tested at: 253fee1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4733/1836/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4733/1836/summary.html

@StoyanStoynev
Copy link
Contributor

+1
Based on jenkins (no issues/diffs) for 253fee1 and the review in #4705. The code changes are identical to #4705 (the PR for 72X).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@Martin-Grunewald
Copy link
Contributor

Hi, @davidlange6
Please include this for the next 71 release as well

davidlange6 added a commit that referenced this pull request Jul 24, 2014
@davidlange6
Merge pull request #4733 from clint-richardson/feature/addGroomingPar…
57e42dd 
…ametersForFastjet

Feature/add grooming parameters for fastjet
@davidlange6 davidlange6 merged commit 57e42dd into cms-sw:CMSSW_7_1_X Jul 24, 2014
Martin-Grunewald
Martin-Grunewald reviewed Jul 28, 2014
View reviewed changes
RecoJets/JetProducers/python/hltak5CaloJets_cfi.py
yCut = cms.double(-1.0),
useFiltering = cms.bool(False),
rFilt = cms.double(-1.0),
nFilt = cms.int(-1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Likewise here:

You added two parameters as cms.int(). This type does not exist.
You need to add it as cms.int32(.).
Please submit a new backport PR to correct this.
You can check for such errors by running

python hltak5CaloJets_cfi.py

@Martin-Grunewald Martin-Grunewald mentioned this pull request Jul 28, 2014
Merged
@Martin-Grunewald
Copy link
Contributor

#4798 #4798 fixes these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed orp-pending reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clint-richardson @cmsbuild @Martin-Grunewald @StoyanStoynev @davidlange6