Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test input files in PhysicsTools/PatAlgos #4766

Merged
merged 1 commit into from Jul 28, 2014
Merged

update test input files in PhysicsTools/PatAlgos #4766

merged 1 commit into from Jul 28, 2014

Conversation

TaiSakuma
Copy link
Contributor

This PR updates the test input files in PhysicsTools/PatAlgos.

This update fixes the error runtestPhysicsToolsPatAlgos in #4709.

The previous update was at #3793.

I made this change interactively at github with a web browser.

@TaiSakuma
update test input files in PhysicsTools/PatAlgos
916eba4 
This update fixes the error *runtestPhysicsToolsPatAlgos* in cms-sw#4709.

The previous update was at cms-sw#3793.

I made this change interactively on github with a web browser.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X.

update test input files in PhysicsTools/PatAlgos

It involves the following packages:

PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1
Tested at: 916eba4
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4766/444/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4766/444/summary.html

@cmsbuild
Copy link
Contributor

+1
Tested at: 916eba4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4766/450/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4766/450/summary.html

@TaiSakuma TaiSakuma mentioned this pull request Jul 25, 2014
Merged
@monttj
Copy link
Contributor

monttj commented Jul 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2014

@cmsbuild
please merge this, we need it to integrate other MET PR

davidlange6 added a commit that referenced this pull request Jul 28, 2014
@davidlange6
Merge pull request #4766 from TaiSakuma/patch-1
e49cc76 
update test input files in PhysicsTools/PatAlgos
@davidlange6 davidlange6 merged commit e49cc76 into cms-sw:CMSSW_7_2_X Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TaiSakuma @cmsbuild @monttj @slava77 @davidlange6