Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing input collection for tauGenJets in miniAOD #4833

Merged

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Jul 30, 2014

In the default PAT, the tauGenJets are made from genParticles. The miniAOD does not contain genParticles, so the links stored in pat::Tau are broken. The prunedGenParticles contain all particles necessary for tauGenJet building and are contained in miniAOD.

Physics output impact: none expected (however the links genJet constituents will work in miniAOD)

Timing impact: might be slightly faster (using smaller collection for tauGenJet production)
Output size impact: none expected (the references were filled also before, only they were pointing to non-existing objects)

@mbluj @gpetruc @arizzi

Can be forward-ported to 71x and 72x

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X.

Changing input collection for tauGenJets in miniAOD

It involves the following packages:

PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Jul 30, 2014

+1
For curiosity, maybe to other experts, I think the link between genJet and genParticle is also broken so the genGenConstituents() can not be called. Would it be also possible to keep the link easily?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@arizzi
Copy link
Contributor

arizzi commented Jul 31, 2014

Right now we just drop/zero genjets constituents but they could be
rekeyd to the packed Gen as we do for regular Jets... But it takes more
space...
Il 30/lug/2014 23:47 "Tae Jeong Kim" notifications@github.com ha scritto:

+1
For curiosity, maybe to other experts, I think the link between genJet and
genParticle is also broken so the genGenConstituents() can not be called.
Would it be also possible to keep the link easily?


Reply to this email directly or view it on GitHub
#4833 (comment).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Aug 4, 2014
Changing input collection for tauGenJets in miniAOD
@davidlange6 davidlange6 merged commit 5958112 into cms-sw:CMSSW_7_0_X Aug 4, 2014
@jpavel jpavel deleted the 70x_taus_miniAOD_tauGenJetInput branch August 6, 2014 13:54
davidlange6 added a commit that referenced this pull request Sep 26, 2014
…37_5230_From720pre6Plus5425

Same as #5525 (#4914 #4833 #4862 #5037 #5230 plus #5425 and other fixes) MiniAOD related
nclopezo added a commit that referenced this pull request Oct 1, 2014
…37_5230_From720pre6Plus5425

Miniaod ports of #4914 #4833 #4862 #5037 #5230  plus #5425 and other fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants