Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniAOD 7.0.X fixes from CSA14 feedback #4914

Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 8, 2014

This set of small commits fixes individual issues that had been pointed out during CSA14 (mostly from https://twiki.cern.ch/twiki/bin/viewauth/CMS/MiniAODCSA14FollowUp)

While there's no change in the dataformats, these fixes really enter the miniAOD production step (unlike e.g. #4862 which was only affecting analysis on top of miniAODs), so to benefit from the fix one has to reproduce the miniAODs.
For the last commit, related to MET corrections, if somebody wants to implement something better feel free to leave it out. In the next two weeks I'll be at a conference and then on holidays, so I will be able to follow up on this PR only intermittently.

@arizzi

…nts (in particular, the process names for l1 information were wrong, so the objects were not kept)
…etter implementation of the whole pat::MET corrections (independent from the uncertainties, and more similar to the one of pat::Jet) would be better, but would be a much more intrusive change, while this one is minimal and preserves compatibility
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2014

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_0_X.

MiniAOD 7.0.X fixes from CSA14 feedback

It involves the following packages:

DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Aug 12, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@arizzi
Copy link
Contributor

arizzi commented Aug 20, 2014

any reason this is not yet merged? (given the tight schedule, it would help to integrate as soon as signed)

davidlange6 added a commit that referenced this pull request Aug 25, 2014
@davidlange6 davidlange6 merged commit 38a327c into cms-sw:CMSSW_7_0_X Aug 25, 2014
davidlange6 added a commit that referenced this pull request Sep 26, 2014
…37_5230_From720pre6Plus5425

Same as #5525 (#4914 #4833 #4862 #5037 #5230 plus #5425 and other fixes) MiniAOD related
nclopezo added a commit that referenced this pull request Oct 1, 2014
…37_5230_From720pre6Plus5425

Miniaod ports of #4914 #4833 #4862 #5037 #5230  plus #5425 and other fixes
@gpetruc gpetruc deleted the miniAODfix-fromCMSSW_7_0_7_patch1 branch September 30, 2015 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants